chmod the docker-credential helper binary#1990
Conversation
|
I think I'm going to need to do this for dotnet-script as well, I'm just testing |
We may be ok as we execute dotnet-script via |
matt-richardson
left a comment
matt-richardson
left a comment
There was a problem hiding this comment.
:simples:
A couple of pretty minor suggestions, but looks like it does what it says on the tin 👍
| PowerShellTasks.PowerShell(_ => _ | ||
| .EnableNoProfile() | ||
| .SetCommand($"chmod +x '{flavourFolder / platformFolder / binary}'")); |
There was a problem hiding this comment.
Any particular reason you're not using File.SetUnixFileMode(path, mode)?
Would be quicker (and cleaner).
There was a problem hiding this comment.
Nope. Didn't know it existed until today 😅
Will change
| flavourFolder / "linux-amd64"); | ||
| Log.Information("Renamed 'linux-x64' folder to 'linux-amd64'"); | ||
|
|
||
| //a known list of binaries to chmod +x |
There was a problem hiding this comment.
not sure you need this comment :)
2 participants
We are packaging a new binary,
docker-credential-octopus(introduced in #1981)However, when loading calamari as a Kubernetes image volume as a read-only filesystem, this needs to be made executable.
We now perform a
chmod +xon an array of binary names