Upgrade to .NET 8.0#1528
Conversation
APErebus
force-pushed
the
ap/net-8.0
branch
from
67cec44 to
d1feb40
Compare
APErebus
force-pushed
the
ap/net-8.0
branch
2 times, most recently
from
accb841 to
437627c
Compare
| () => | ||
| { | ||
| //if this is windows, publish a netfx version of the tests project | ||
| if (OperatingSystem.IsWindows()) | ||
| { | ||
| var publishedLocation = DoPublish("Calamari.Tests", Frameworks.Net462, nugetVersion); | ||
| var zipName = $"Calamari.Tests.{Frameworks.Net462}.{nugetVersion}.zip"; | ||
| publishedLocation.CompressTo(ArtifactsDirectory / zipName); | ||
| } | ||
| } |
There was a problem hiding this comment.
Renamed this to make it clear what this zip file actually is
|
|
||
|
|
||
| [PublicAPI] | ||
| Target OncePerWindowsOrLinuxTesting => |
There was a problem hiding this comment.
Moved these into Nuke (out of the TeamCity build steps)
| { | ||
| public static class DotNetTestSettingsExtensionMethods | ||
| { | ||
| public static DotNetTestSettings EnableTeamCityTestLogger(this DotNetTestSettings settings, AbsolutePath outputDirectory) |
There was a problem hiding this comment.
Borrowed from Server
There was a problem hiding this comment.
Not sure about the interaction with
Line 665 in d757b73
That I added recently. I will have a look and check/circle back
| @@ -1,4 +1,4 @@ | |||
| #r "nuget: NuGet.Commands, 6.10.0" | |||
| #r "nuget: NuGet.Commands, 6.10.0.107" | |||
There was a problem hiding this comment.
the upgrade in dotnet-script to 1.6 changed this version
Jtango18
left a comment
Jtango18
left a comment
There was a problem hiding this comment.
Looks like a great upgrade.
Flagging as "Request Changes" because it won't build locally using the Nuke script for me.
Investigating why.
Because of the temp install of net8 to latest version, OutDir and Publish dir may not be correctly set - this falls back to a safe value preventing unzip errors.
Jtango18
left a comment
Jtango18
left a comment
There was a problem hiding this comment.
Added some fixes to allow x-plat Nuke builds - this is GTG from my perspective
zentron
left a comment
zentron
left a comment
There was a problem hiding this comment.
Nice one. Moving forward
5 participants
.NET 6.0 is out of date/support, we should upgrade to .NET 8.0
This also includes the upgrade of
dotnet-scriptto1.6. THis is due to a some known vulnerabilities with its dependencies indotnet-script1.4.NOTE: When this is merged, there will need to be some changes to the TeamCity configuration to support this. I will manually make those changes after merging