fix: read TURN server url from local candidate and register TURN servers - #5
Open
balazskreith wants to merge 1 commit into
Open
fix: read TURN server url from local candidate and register TURN servers#5balazskreith wants to merge 1 commit into
balazskreith wants to merge 1 commit into
Conversation
- usingTURN / selectedIceCandiadtePairForTurn read the local candidate's url (remote candidates never carry one per W3C webrtc-stats), and usingTURN no longer requires the url at all - candidateType 'relay' suffices; the url only gates TURN-server attribution. 'turns:' (TLS) urls now match too. - ObservedTURN.addPeerConnection: derive the server key by stripping the url query instead of new URL() (WHATWG URL parses turn: schemes as opaque paths with empty hostname), register the created server in this.servers, and register the peer connection on the server so update()/removePeerConnection actually work. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RPdM2dcBs16j2uhz2aLenY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude-Session: https://claude.ai/code/session_01RPdM2dcBs16j2uhz2aLenY