Repository navigation
perf(version): cache parsed version tuples in compareVersions - #740
Merged
sonukapoor merged 11 commits intoJun 23, 2026
Merged
Conversation
…with pre-release segments
sonukapoor
requested changes
Jun 22, 2026
sonukapoor
left a comment
Collaborator
There was a problem hiding this comment.
The implementation is clean - Object.freeze on cached arrays is a nice touch. Two small things before this is good to go.
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Collaborator
|
Branch is one commit behind main after #742 merged. Could you rebase when you get a chance? No conflicts expected — the files don't overlap. |
sonukapoor
approved these changes
Jun 23, 2026
Collaborator
|
Merged — thank you @luojiyin1987! |
Collaborator
Author
something I need to do ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #739
Summary
compareVersionsis on the hot path: candidate sorting, range matching, and fix validation all call it repeatedly. Each call splits strings and maps them to numbers. For a packument likelodashwith 100+ versions, sorting callscompareVersions~700 times, re-parsing the same strings each time.Changes
Map<string, readonly (number|string)[]>cache insrc/utils/version.tsparseVersionTuplethat checks the cache before splittingObject.freezeto prevent mutation of cached arraysreadonlyfor TypeScript-level enforcementVerification