Repository navigation
chore: replace em dashes in source and output strings (#1283) - #1285
Conversation
|
Update: this branch has been refreshed with the latest |
4d8e5cf to
c64488b
Compare
Replace all 54 em dashes across 17 files under src/ with colons, hyphens, or periods, and update the tests that assert those strings. Also clean README.md, docs/output-before-after.md, and scripts/clean-dist.mjs. Comments and JSDoc use a plain hyphen.
c64488b to
47de9ac
Compare
sonukapoor
left a comment
There was a problem hiding this comment.
Exactly the scope of #1283 and nothing beyond it: 54 removed across the 17 files it counted, and src/docs/CONTRIBUTING.md correctly left alone since the issue's count excludes it. 2319 tests, build clean.
I went looking for the one way a mechanical replacement like this bites, a dash sitting somewhere parsed rather than printed, and there is nothing: every changed occurrence is inside a string literal, a template literal or a comment. Three lines tripped my own crude filter and all three are false positives, a trailing comment on a line containing === and the two HTML <title> lines.
Approved. The dozen left in CONTRIBUTING.md are our own writing and our own follow-up, not yours.
|
Same situation as #1269, where I have put the detail. The sweep itself is complete: |
|
Merged, thank you @prx-my. Worth saying what made this one easy to take: you updated every assertion in lockstep with the string it covers, so the suite stayed at full green the whole way rather than needing anything reconciled at the end. On a change touching thirty-six files that is the difference between a review and an archaeology session. |
Closes #1283.
What changed
src/(43 in emitted strings, 11 in comments/JSDoc)::where a clause follows (e.g.1 packument fetch failed: remediation guidance may be incomplete.),;/period where a colon read poorly<title>separators use-(CVE Lite - <project>)-multi-folder-scan,scanner-cache,html-reporter) after reading each assertionREADME.md(10),docs/output-before-after.md(8),scripts/clean-dist.mjs(1). Thedocs/sample output now matches current source (printers.tscolon,formatters.tshyphens)src/skills/content.tsoutput by eye (shipped AI-assistant docs, least coverage)Verification
grep -rn "—" src --include="*.ts"returns nothingnpm testpasses (163 suites, 2249 tests)npm run buildis cleanNotes
tests/output.test.ts:2944intentionally keepsnot.toContain("—")as the convention guard.website/docs/(859) andexamples/(68) still contain em dashes; can be a follow-up docs PR.