You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(report): restore lockfileSource to report.json payload (#1263) - #1268
Restores lockfileSource to report.json alongside scannedAt and cliVersion in handleSingleFolderScan (src/scan/single-scan.ts).
When #1176 unified report.json with the --json payload builder, lockfileSource was omitted because it is not part of the standard --json output. Adding lockfileSource: reportData.lockfileSource to jsonPayload restores the field so report.json remains a strict superset of the --json shape.
Also updates test assertions in tests/html-reporter.test.ts and tests/e2e/validation-and-outputs.test.ts to verify lockfileSource presence in report.json and absence from the standard --json payload.
Closing this as a duplicate of #1264, which merged as d378bbe and closes #1263. Yours was fifteen minutes behind it and the project gives the oldest duplicate the first chance.
One thing from yours I did want to keep, so it is on the record: you were the only one of the two to notice that the negative assertion in tests/html-reporter.test.ts reads as a claim about report.json once the field comes back. You picked a different remedy than I would, since that assertion is a live guard on the shared --json builder and overwriting it loses coverage, but the observation was right and neither #1264 nor I spotted it. A comment making it explicit is going on my list.
Thank you for the detailed feedback and explanation, @sonukapoor. Glad the observation on the test assertion was helpful. Appreciate your time reviewing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Restores
lockfileSourcetoreport.jsonalongsidescannedAtandcliVersioninhandleSingleFolderScan(src/scan/single-scan.ts).When #1176 unified
report.jsonwith the--jsonpayload builder,lockfileSourcewas omitted because it is not part of the standard--jsonoutput. AddinglockfileSource: reportData.lockfileSourcetojsonPayloadrestores the field soreport.jsonremains a strict superset of the--jsonshape.Also updates test assertions in
tests/html-reporter.test.tsandtests/e2e/validation-and-outputs.test.tsto verifylockfileSourcepresence inreport.jsonand absence from the standard--jsonpayload.Closes #1263