client: support post queries and declared result members#803
Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Coverage OverviewLanguages: C# C# / dotnet/coberturaThe overall coverage in the branch is 56%. The coverage in the branch is 55%. Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 51.26% 51.87% +0.60%
==========================================
Files 174 174
Lines 10281 10337 +56
Branches 1057 1067 +10
==========================================
+ Hits 5271 5362 +91
+ Misses 4750 4720 -30
+ Partials 260 255 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends the OSLC client query support by adding HTTP POST-based query submission and improving how query results detect membership predicates (including LDP containers and explicitly declared member relations), with corresponding tests and changelog entries.
Changes:
- Add
OslcQuery.SubmitPost()to submit OSLC query parameters viaapplication/x-www-form-urlencodedPOST. - Improve
OslcQueryResultmembership detection (explicit member relation, LDPhasMemberRelation/membershipResource, andldp:contains) and totalCount parsing from RDF literals. - Add/extend client tests covering POST body encoding and membership predicate resolution behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| OSLC4Net_SDK/Tests/OSLC4Net.Client.Tests/OslcQueryTests.cs | New tests covering member relation validation and POST form body encoding (no double-encoding). |
| OSLC4Net_SDK/Tests/OSLC4Net.Client.Tests/OslcQueryResultTests.cs | Expanded tests for explicit membership predicates, LDP container behavior, and literal totalCount parsing. |
| OSLC4Net_SDK/OSLC4Net.Client/Oslc/Resources/OslcQueryResult.cs | Update membership predicate resolution logic and parse totalCount from ILiteralNode. |
| OSLC4Net_SDK/OSLC4Net.Client/Oslc/Resources/OslcQuery.cs | Add explicit member-relation support and implement POST submission path. |
| CHANGELOG.md | Document new POST query support and query result membership/totalCount fixes. |
Uh oh!
There was an error while loading. Please reload this page.