Calls to stop before connected cause lockups. #13

Activity

1. bleckers

   added

   bugSomething isn't workingSomething isn't working

   on Jun 14, 2020
2. prototypicalpro commented on Jun 14, 2020

   

   prototypicalpro

   on Jun 14, 2020

   Member

   More actions

   Is the behavior a crash or a freeze? In my experience BearSSL attempts to close the connection by sending a close_notify (which is usually ignored) and then times out waiting for a response.
3. prototypicalpro commented on Jun 14, 2020

   

   prototypicalpro

   on Jun 14, 2020

   Member

   More actions

   I think 4707ea4 should fix the close_notify issue, would you give master latest a shot?

   👍React with 👍1Reacted by Blair Wyatt
4. bleckers commented on Jun 15, 2020

   

   bleckers

   on Jun 15, 2020

   ContributorAuthor

   More actions

   The behaviour is a crash rather than a freeze. The new commit fixes this with a fresh stop before connect, after a client has connected and disconnected AND if the client is connected.
5. bleckers

   closed this as completedon Jun 15, 2020
6. bleckers commented on Jun 15, 2020

   

   bleckers

   on Jun 15, 2020

   Last edited by bleckers

   ContributorAuthor

   More actions

   Oh just to add, if you have network connectivity, a connected socket, but temporarily no route to the server and are using the Arduino Ethernet 2.0 library, you will need the following change in the EthernetClient.cpp for this commit to fix these issues (as calls to get_arduino_client().flush() in this configuration will hang indefinitely when there's no route). This is also true for calls to flush in the m_update_engine of SSLClient, and considering the lack of development effort in Ethernet, it might have to be a recommendation in SSLClient (particularly if using PubSubClient because of the regular pings which are susceptible to minor lapses in network connectivity).

   void EthernetClient::flush()
   {
   	unsigned long start = millis();
   	while (sockindex < MAX_SOCK_NUM) {
   		if (millis() - start > _timeout) 
   		{
   			stop();
   			return;
   		}
   		uint8_t stat = Ethernet.socketStatus(sockindex);
   		if (stat != SnSR::ESTABLISHED && stat != SnSR::CLOSE_WAIT) return;
   		if (Ethernet.socketSendAvailable(sockindex) >= W5100.SSIZE) return;
   	}
   }
   

   This has been PRed into Paul's "fork" of the Arduino repo - PaulStoffregen/Ethernet@master...bleckers:patch-1
7. prototypicalpro commented on Jun 15, 2020

   

   prototypicalpro

   on Jun 15, 2020

   Member

   More actions

   Hmmm yeah, I don't think I have a good way of enforcing a timeout on Client::flush without modifying the client implementation. I will add a note in the README about this, and patch EthernetLarge as soon as your pull request is merged.
8. prototypicalpro

   added a commit that references this issue on Jun 15, 2020

   Merge pull request #14 from OPEnSLab-OSU/develop

   ...

   This issue will close once commit f40b9c4 is merged into the 'master' branch.

   f40b9c4
9. prototypicalpro

   linked a pull request that will close this issueFix #13 #14on Jun 15, 2020