fix: don't return continuation points on BadNoContinuationPoints (#4022) [backport to master378] - #4268
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master378 #4268 +/- ##
=============================================
- Coverage 60.19% 60.16% -0.04%
=============================================
Files 378 378
Lines 79067 79068 +1
Branches 13838 13838
=============================================
- Hits 47598 47572 -26
- Misses 27047 27079 +32
+ Partials 4422 4417 -5
🚀 New features to boost your workflow:
|
Backport of 399747f from master to master378. - Dispose and clear the continuation point when FetchReferences hits the no-continuation-points path. - Only copy a continuation point into Browse and BrowseNext results when the operation completed successfully. - Add regression tests verifying both Browse and BrowseNext return BadNoContinuationPoints without a continuation point when the continuation-point quota is exhausted. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
marcschier
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of commit 399747f (#4022) from
mastertomaster378.Fixes
BrowseandBrowseNextso they do not return a usable continuation point when the server reportsBadNoContinuationPoints, and adds regression tests covering both code paths.Problem
Per OPC UA Part 4, if the server cannot allocate another continuation point for a
Browse/BrowseNextoperation, the result should beBad_NoContinuationPointsand the server must not also return a usable continuation point. PreviouslyFetchReferencescould returnBadNoContinuationPointswhile still passing a live continuation point back to its callers, producing a contradictory response (BadNoContinuationPointswith a non-emptyContinuationPoint), andBrowseNextcould overwrite the error withGood.Changes
FetchReferenceshits the no-continuation-points path.BrowseandBrowseNextresults when the operation completed successfully (ServiceResult.IsGood(error)).BrowseandBrowseNext, adapted to themaster378server API.Notes
The upstream commit targets the v2.0 APIs (
ArrayOf/ByteString); the source fix and tests here were adapted to themaster378API (byte[]continuation points,BrowseResultCollection/ByteStringCollection, 4-argOperationContextconstructor). Both new tests pass.