Fix ServerTimestamp update on read of stored/static nodes (#4257) - #4260
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (62.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master378 #4260 +/- ##
=============================================
+ Coverage 60.19% 60.21% +0.01%
=============================================
Files 378 378
Lines 79067 79069 +2
Branches 13838 13840 +2
=============================================
+ Hits 47598 47614 +16
+ Misses 27047 27034 -13
+ Partials 4422 4421 -1
🚀 New features to boost your workflow:
|
- Backport ServerTimestamp update logic on Read from master (#3960) - In CustomNodeManager and CoreNodeManager, stamp ServerTimestamp with current read time for stored/static nodes whose SourceTimestamp is older than read time - Maintain SourceTimestamp and ServerTimestamp alignment for dynamically produced values during Read (such as ServerStatus children) - Add unit test verifying fresh ServerTimestamp after writing a static node Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
marcschier
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the fix for ServerTimestamp updating on Read operations for stored/static nodes to master378 (1.5.378), addressing issue #4257 (part 2).
Details
eadTime (e.g. after a Write).
Fixes #4257 (ServerTimestamp behavior)