Skip to content

Fix ServerTimestamp update on read of stored/static nodes (#4257) - #4260

Merged
marcschier merged 1 commit into
master378from
romanett-eval-issue-4257-timestamps
Aug 18, 2026
Merged

Fix ServerTimestamp update on read of stored/static nodes (#4257)#4260
marcschier merged 1 commit into
master378from
romanett-eval-issue-4257-timestamps

Conversation

@romanett

Copy link
Copy Markdown
Contributor

Summary

Backports the fix for ServerTimestamp updating on Read operations for stored/static nodes to master378 (1.5.378), addressing issue #4257 (part 2).

Details

  • In CustomNodeManager and CoreNodeManager, ensure ServerTimestamp is stamped with the read time for stored/static nodes whose SourceTimestamp is older than
    eadTime (e.g. after a Write).
  • Retain matching SourceTimestamp and ServerTimestamp for dynamically produced values generated during Read (such as ServerStatus children).
  • Adds unit test ReadStaticVariableStampsFreshServerTimestampAfterWriteAsync in ReferenceServerTest.cs to verify that after writing to a static variable, subsequent reads return ServerTimestamp stamped with the current read time.

Fixes #4257 (ServerTimestamp behavior)

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (db256c6) to head (9aab965).

Files with missing lines Patch % Lines
...aries/Opc.Ua.Server/NodeManager/CoreNodeManager.cs 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (62.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           master378    #4260      +/-   ##
=============================================
+ Coverage      60.19%   60.21%   +0.01%     
=============================================
  Files            378      378              
  Lines          79067    79069       +2     
  Branches       13838    13840       +2     
=============================================
+ Hits           47598    47614      +16     
+ Misses         27047    27034      -13     
+ Partials        4422     4421       -1     
Files with missing lines Coverage Δ
...ies/Opc.Ua.Server/NodeManager/CustomNodeManager.cs 60.92% <100.00%> (-0.20%) ⬇️
...aries/Opc.Ua.Server/NodeManager/CoreNodeManager.cs 13.42% <0.00%> (-0.01%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Backport ServerTimestamp update logic on Read from master (#3960)
- In CustomNodeManager and CoreNodeManager, stamp ServerTimestamp with current read time for stored/static nodes whose SourceTimestamp is older than read time
- Maintain SourceTimestamp and ServerTimestamp alignment for dynamically produced values during Read (such as ServerStatus children)
- Add unit test verifying fresh ServerTimestamp after writing a static node

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@romanett romanett linked an issue Aug 15, 2026 that may be closed by this pull request
@romanett romanett added the 1.5.378 Only affects 1.5.378 (pre 2.0) label Aug 15, 2026
@romanett
romanett requested a review from marcschier August 15, 2026 11:45
@marcschier
marcschier merged commit 2ae373f into master378 Aug 18, 2026
110 of 111 checks passed
@marcschier
marcschier deleted the romanett-eval-issue-4257-timestamps branch August 18, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.5.378 Only affects 1.5.378 (pre 2.0)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with SourceTimestamp and ServerTimestamp

2 participants