Skip to content

[19.0] [FIX] fs_attachment: missing size parameter in _file_read#557

Merged
OCA-git-bot merged 1 commit intoOCA:19.0from
camptocamp:19.0-fix-fs-attachment-missing-size
Mar 4, 2026
Merged

[19.0] [FIX] fs_attachment: missing size parameter in _file_read#557
OCA-git-bot merged 1 commit intoOCA:19.0from
camptocamp:19.0-fix-fs-attachment-missing-size

Conversation

@ivantodorovich
Copy link
Contributor

@ivantodorovich ivantodorovich commented Mar 2, 2026

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@ivantodorovich ivantodorovich marked this pull request as ready for review March 2, 2026 14:05
@ivantodorovich ivantodorovich changed the title [19.0] [FIX] fs_attachment: missing read parameter in _file_read [19.0] [FIX] fs_attachment: missing size parameter in _file_read Mar 2, 2026
@lmignon
Copy link
Contributor

lmignon commented Mar 2, 2026

tests are 🔴
even if the fix seems the right one, without a working CI, it's not possible to merge ...

@ivantodorovich
Copy link
Contributor Author

@gurneyalex
Copy link
Member

I triggered a merge on #558 you may want to rebase in a few minutes @ivantodorovich

@ivantodorovich ivantodorovich force-pushed the 19.0-fix-fs-attachment-missing-size branch from eaa113d to 87448f5 Compare March 4, 2026 13:41
@ivantodorovich
Copy link
Contributor Author

Thanks! This is ready now

@lmignon
Copy link
Contributor

lmignon commented Mar 4, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-557-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 4, 2026
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 19.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 19.0-ocabot-merge-pr-557-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8b24bdb into OCA:19.0 Mar 4, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5f660a6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants