[17.0][FIX] queue:job: Handle zero max_retries in job retry logic#816
Conversation
|
Hi @guewen, |
|
TSGTM. I have verified that these changes ensure the job will be re-enqueued indefinitely when |
There was a problem hiding this comment.
Pull Request Overview
Fixes handling of zero max_retries in job retry logic by treating zero as NULL to prevent premature job failure. The issue occurred when jobs with max_retries=0 were incorrectly marked as failed instead of being requeued.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fb1f1c4 to
fa39043
Compare
AnizR
left a comment
There was a problem hiding this comment.
Code LGTM, thanks for your contribution!
fa39043 to
97f20e2
Compare
|
@OCA/queue-maintainers Can this be merged? |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 357fbd0. Thanks a lot for contributing to OCA. ❤️ |
|
Backport to 16.0 in #817 |
|
And cherry-picked into #749 for 18.0 |
Resolves #814