[18.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 18.0#744
[18.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 18.0#744OCA-git-bot merged 22 commits intoOCA:18.0from
Conversation
[UPD] Update queue_job_batch.pot
* incorrect sintax in security rule * change missleading name of security rule
standard migration and some little ux improvements: now hide button is a fa-check button that on click just marks as read the batch, do not navigate to it and updates immediately the systray.
* The batch enqueued method is removed, to better reflect the fact that the batch's jobs are executed immediately. * The batch state `draft` is is renamed to `pending`, for the same purpose. * The batch's `is_read` field is initialized as `False` (default value), and only set to `True` when it's actually read. * We now use `identity_exact` for the batch `check_state` delayed method. * The widget has been reimplemented due to the heavy refactoring made in the core `mail` app: odoo/odoo@7710c333
yankinmax
left a comment
yankinmax
left a comment
There was a problem hiding this comment.
Technical migration seems ok! Thanks @ivantodorovich
| return record | ||
|
|
||
| @api.depends("job_ids") | ||
| @api.depends("job_ids.state") |
There was a problem hiding this comment.
do we really need this depends? Job count is not stored.
There was a problem hiding this comment.
Not really, for the UI. I'd be necessary when reading the field programatically, though, without invalidating caches. It's a habit 😓
|
/ocabot migration queue_job_batch |
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 3a91fbb. Thanks a lot for contributing to OCA. ❤️ |
13 participants
Superseeds:
Changes:
draftis is renamed topending, for the same purpose.is_readfield is initialized asFalse(default value), and only set toTruewhen it's actually read.identity_exactfor the batchcheck_statedelayed method.mailapp: odoo/odoo@7710c333