[FIX][18.0] queue_job: indicate that run_job need a read/write connection#742
Conversation
Without this fix, if db_replica_host is set, Odoo might pass a readonly database cursor and the FOR UPDATE in the method would fail.
|
Hi @guewen, |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0767459. Thanks a lot for contributing to OCA. ❤️ |
|
Thanks for the quick merge! Much appreciated. |
|
@vincent-hatakeyama Can I ask you, I'm curious why this is necessary. https://github.com/odoo/odoo/blob/b2d709b/odoo/http.py#L701-L703 seems to imply that the cursor will default to read/write. Where is the default determined as True? |
|
@vincent-hatakeyama Oh, never mind. Found it in https://github.com/odoo/odoo/blob/b2d709b/odoo/http.py#L863, when auth='none'. |
Without this fix, if db_replica_host is set, Odoo might pass a readonly database cursor and the FOR UPDATE in the method would fail.