Closed
Conversation
b46ee67 to
4c78c0e
Compare
4c78c0e to
210f952
Compare
amh-mw
suggested changes
Mar 7, 2024
Member
amh-mw
left a comment
There was a problem hiding this comment.
This generally feels like it should be an improvement to queue_job_batch, not its own module. I'm setting up a local test environment today and will report back with observations.
| channel=None, | ||
| identity_key=None, | ||
| batch_size=None, | ||
| batch_count=None, |
Member
There was a problem hiding this comment.
This seems straightforward enough, but the corresponding change to def delayable is missing.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Contributor
|
@paradoxxxzero shall we close this one in favor of #658 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows to seemlessly split a big job into smaller jobs.
It uses
queue_job_batchto group the created jobs into a batch.Example:
This will create 34 jobs, each one copying 30 partners (except the last one which will copy 10) and will group them into a batch.
Instead of
batch_size, one can also usebatch_countto specify the number of batches to create instead.