queue_job: add exec time to view some stats

[simahawk]

No description provided.

[simahawk]

@guewen I guess the test is wrong here because date_started in theory should be there always if you are calling set_done, right? It should call set_started before. See https://travis-ci.com/github/OCA/queue/jobs/481537133#L1082

[guewen]

I guess the test is wrong here because date_started in theory should be there always if you are calling set_done, right? It should call set_started before

It's not wrong, for this test, the initial state started had no impact on set_done. It's a unit test, it doesn't test the full flow.
You added a new dependency (date_started) in this unit, so you have to be sure the initial state of the test set it correctly.
You shouldn't call set_started before, because then the test would test set_started and set_done.
You only need to set job_a.date_started = xxx as this is the initial state you miss.

[simahawk]

better?

[guewen]

Yes, thanks!! ❤️

[sebalix]

Small comment, approving

[etobella]

Code Review

[guewen]

I think a pivot view gives better information:

<pivot string="Queue Job">
    <field name="exec_time" type="measure"/>
    <field name="job_function_id" type="row"/>
    <field name="date_done" type="col" interval="week"/>
</pivot>

Example:

Note: in this example, I used group_operator="avg" on the field, which I'm not sure we want.

[guewen]

The average is really cool on this view as we can see if it grows over time...

[simahawk]

looks good. At least is a great start!

[guewen]

Pushed a fixup for pivot view + group by avg by default. I added a mention in string and help for the avg to prevent confusion.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[guewen]

Hi @simahawk :)

I squashed my commit and rebased, can I remove the work in progress label? I'd like to merge if the build is green.

[guewen]

I squashed my commit and rebased, can I remove the work in progress label? I'd like to merge if the build is green.

Oh no sorry, I couldn't push it because I do no longer have push writes here 😆
Could you do it?

[simahawk]

welcome back! :)
It's done!

[guewen]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-309-by-guewen-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 9bf3f24. Thanks a lot for contributing to OCA. ❤️