Merged
Conversation
The _slots attribute is no longer used. The field properties are defined as class attributes. See odoo/odoo#48705
Split one model per file, as advised in the contribution guide.
Now that the `@job` decorater is deleted, `identity_exact` is the only thing we may need to import from "job.py". Being able to import it from "odoo.addons.queue_job" is nicer than from "odoo.addons.queue_job.job".
Member
Author
|
Green! 🟢 |
eantones
approved these changes
Nov 30, 2020
Contributor
eantones
left a comment
eantones
left a comment
There was a problem hiding this comment.
Thank you for all the improvements. LGTM!
Member
Author
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 41f5d80. Thanks a lot for contributing to OCA. ❤️ |
Contributor
|
/ocabot migration queue_job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Several PRs have already been opened for this migration: #263, #286, #288. Thanks a lot to @eantones, @sebastienbeau, @dnplkndll for them, as the result here is a joint work for the migration.
As the runbot build was still red on these PRs (the missing part was #286 (comment)), I opened yet a new one... As we switch the version, I took the opportunity to add a few more commits:
JobSerializedfield for 14.0 (fix the warnings in runbot)identity_exact(from odoo.addons.queue_job import identity_exact)Some commits have details in their body.
I hope the runbot build will now be green, and we'll be able to merge quickly 🤞.
@eantones, @sebastienbeau, @atchuthan, @CasVissers-360ERP, @t-900-a, @aliencrash, @dnplkndll, @bealdav as you all participated in the previous pull requests, in code, comments, tests, reviews, I thank you one more time for your help (it feels good to have your support), if you can review my last changes and put your approvals, we can merge this fast.