[13.0] Refactor storage of job records with "sudo" support by guewen · Pull Request #281 · OCA/queue

guewen · 2020-11-13T13:33:32Z

Replaces #272

Previously, the "main" record, the one on which the job works, was stored in 3 fields: model_name, user_id and record_ids (and the support for any new field such as sudo or context would need a new field). The records of args and kwargs are serialized in JobSerialized fields.

This PR unifies the way they are stored: the "main" record is now stored in a JobSerialized field as well.
The support of the su flag (which means the record was sudo()-ed), is added in the second commit, which shows how we benefit from the refactor.

The original fields are kept:

model_name is stored for the UI (used in search or groupby)
user_id is stored for the same reason, but also has a inverse method that updates the serialized record
record_ids is kept only for backward compatibility, but could be removed in 14.0

These fields contain the current model and record ids and user id the job works on. Storing them as separate fields does not allow to take benefits on the "JobSerialized" field, which keeps the original user, and later the 'su' flag. We could store the context there as well (or a cleaned one). Use computed fields to keep the model_name, record_ids, user_id fields for backward compatibility. The model_name should stay anyway for the searches on the UI, and the user_id for the same reason + possibility to edit the user.

Which means that the record the job is working on, or any record argument of the job keeps the 'su' flag.

simahawk

LG (just code review)

simahawk · 2020-11-13T13:46:22Z

queue_job/fields.py

+        list: "[]",
+        tuple: "[]",
+        models.BaseModel: lambda env: json.dumps(
+            {"_type": "odoo_recordset", "model": "base", "ids": [], "uid": env.uid}


shall we store record.context too?

This clearly opens this possibility, this is definitely where the context has to be stored. I mentioned it in the commit message :)
However, there are some questions about what should be allowed or not to store in the context (cf #121), also whether we should or not always store it (can take useless space?), so it should not be part of this PR.

created #283

guewen · 2020-11-18T08:28:25Z

/ocabot merge nobump

(version is changed in the PR already)

OCA-git-bot · 2020-11-18T08:28:48Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-281-by-guewen-bump-nobump, awaiting test results.

OCA-git-bot · 2020-11-18T09:03:13Z

Congratulations, your PR was merged at 644a4a5. Thanks a lot for contributing to OCA. ❤️

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

Guewen Baconnier added 2 commits November 13, 2020 14:26

Store 'su' flag in records stored in JobSerialized fields

cacfd14

Which means that the record the job is working on, or any record argument of the job keeps the 'su' flag.

guewen mentioned this pull request Nov 13, 2020

Store 'su' flag in jobs #272

Closed

simahawk approved these changes Nov 13, 2020

View reviewed changes

guewen mentioned this pull request Nov 13, 2020

[feature] Storing context in recordsets #283

Closed

TDu approved these changes Nov 13, 2020

View reviewed changes

OCA-git-bot added the approved label Nov 13, 2020

OCA-git-bot added the bot is merging ⏳ label Nov 18, 2020

OCA-git-bot merged commit 11219f6 into OCA:13.0 Nov 18, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 18, 2020

guewen pushed a commit to guewen/queue that referenced this pull request Dec 1, 2020

Fix required sudo in Job

d5c74d2

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

guewen mentioned this pull request Dec 1, 2020

[13.0] Fix required sudo in Job #291

Merged

guewen pushed a commit to guewen/queue that referenced this pull request Dec 1, 2020

Fix required sudo in Job

9ad2003

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

guewen pushed a commit to guewen/queue that referenced this pull request Dec 1, 2020

Fix required sudo in Job

578ad6c

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

guewen mentioned this pull request Dec 1, 2020

[14.0] Fix required sudo in Job #292

Merged

etobella pushed a commit to tegin/queue that referenced this pull request Apr 19, 2021

Fix required sudo in Job

7078a4e

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

guewen mentioned this pull request Jul 13, 2021

[IMP] queue: Store context in order to reuse it #121

Closed

guewen mentioned this pull request Nov 10, 2021

[13.0][IMP] queue_job current company #365

Closed

bizzappdev pushed a commit to BizzAppDev-Systems/queue that referenced this pull request Nov 23, 2023

Fix required sudo in Job

347ea7b

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

bizzappdev pushed a commit to BizzAppDev-Systems/queue that referenced this pull request Nov 23, 2023

Fix required sudo in Job

d49297f

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

nguyenminhchien pushed a commit to nguyenminhchien/queue that referenced this pull request Nov 25, 2023

Fix required sudo in Job

8cc95e8

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

QuocDuong1306 pushed a commit to QuocDuong1306/queue that referenced this pull request Sep 19, 2024

Fix required sudo in Job

4a421f2

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

QuocDuong1306 pushed a commit to QuocDuong1306/queue that referenced this pull request Sep 24, 2024

Fix required sudo in Job

4432771

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

thienvh332 pushed a commit to thienvh332/queue that referenced this pull request Oct 7, 2024

Fix required sudo in Job

4360172

Following changes of OCA#281 The initial sudo() is lost when we call "with_env()" with a False su flag. Ensure the read job.record keeps a su flag.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[13.0] Refactor storage of job records with "sudo" support#281

[13.0] Refactor storage of job records with "sudo" support#281
OCA-git-bot merged 2 commits intoOCA:13.0from
guewen:13.0-store-main-record-as-json-with-su

guewen commented Nov 13, 2020

Uh oh!

simahawk left a comment

Uh oh!

simahawk Nov 13, 2020

Uh oh!

guewen Nov 13, 2020

Uh oh!

guewen Nov 13, 2020

Uh oh!

guewen commented Nov 18, 2020

Uh oh!

OCA-git-bot commented Nov 18, 2020

Uh oh!

OCA-git-bot commented Nov 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

guewen commented Nov 13, 2020

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

guewen Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

guewen Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

guewen commented Nov 18, 2020

Uh oh!

OCA-git-bot commented Nov 18, 2020

Uh oh!

OCA-git-bot commented Nov 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants