[REM] xml-template-prettier-incompatible: Remove check - #198
Merged
moylop260 merged 1 commit intoAug 14, 2026
Merged
Conversation
There are too many tag variants able to inject a real newline instead of being just a style change made by prettier, so the check can not cover them reliably and it reports only a small subset of the real cases. Removing it also avoids the need of changing `xmlWhitespaceSensitivity: "strict"` in `.prettierrc.yml`, which is kept as is in order to prevent unexpected text insertion errors in production. Revert of dc69ca4 (OCA#150) related to OCA#149
moylop260
added a commit
to vauxoo-dev/pre-commit-vauxoo
that referenced
this pull request
Aug 14, 2026
Release that drops the `xml-template-prettier-incompatible` check (OCA/odoo-pre-commit-hooks#198).
moylop260
added a commit
to Vauxoo/pre-commit-vauxoo
that referenced
this pull request
Aug 14, 2026
…ist (#267) The check is being removed upstream in OCA/odoo-pre-commit-hooks#198, so there is nothing left to disable and the entry only adds noise to the generated `.oca_hooks.cfg`. * [IMP] cfg: Bump odoo-pre-commit-hooks to v0.2.26 Release that drops the `xml-template-prettier-incompatible` check (OCA/odoo-pre-commit-hooks#198).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
xml-template-prettier-incompatiblecheck added in #150.Why
<textarea><t t-out=.../></textarea>) and can not be made reliable without a lot of false negatives/positives.xmlWhitespaceSensitivity: "strict"in.prettierrc.yml, which is kept as is in order to prevent unexpected text insertion errors in production.Changes
checks_odoo_module_xml.py: dropverify_template_prettier_incompatible(), its entry in@utils.only_required_for_checksand the call fromcheck_xml_templates()test_repo/test_module/website_templates.xml: drop the<textarea>fixturestests/test_checks.py: drop the expected errors entryREADME.md: regenerated withtox -e update-readmeRelated to #149