[ADD] oca_checklog_odoo: configurable failure on WARNING log messages

[PabloEForgeFlow]

This PR implements #10 by doing the following:

• Add bin/oca_checklog_odoo, which fails on stdin WARNING log messages when OCA_ENABLE_CHECKLOG_ODOO is set
• Pipe oca_init_test_database and oca_run_tests to oca_checklog_odoo
• Test functionality in tests/test_checklog.py

[sbidoul]

I've had a brief look, and the PR looks great.

Regarding the python 3.5 test, well... I wonder if OCA should not simply stop supporting Odoo 11.

[sbidoul]

I know I proposed this approach, but I wonder if we could use a simple unix command instead such as cat?

[sbidoul]

I mean, specifically for the case when we don't want to check logs

[PabloEForgeFlow]

Yeah, that would probably make more sense. Changed it just now

[hparfr]

minor remark about typo

[PabloEForgeFlow]

I've had a brief look, and the PR looks great.

Regarding the python 3.5 test, well... I wonder if OCA should not simply stop supporting Odoo 11.

I've had a brief look, and the PR looks great.

Regarding the python 3.5 test, well... I wonder if OCA should not simply stop supporting Odoo 11.

Apparently it's been almost a decade since 3.5 was released, so yeah it might be time to let it go

[rousseldenis]

LGTM

[sbidoul]

I'll try to find a moment to test this soon. Main thing I want to check is if the colors are preserved in the logs.

@PabloEForgeFlow would you also do the PR on oca/oca-addons-repo-template to add the copier question to enable this (enabled by default on Odoo >= 18)?

[PabloEForgeFlow]

I'll try to find a moment to test this soon. Main thing I want to checks is if the colors are preserved in the logs.

@PabloEForgeFlow would you also do the PR on oca/oca-addons-repo-template to add the copier question to enable this (enabled by default on Odoo >= 18)?

Sure, I'm a bit busy at the moment, but I'll do that as soon as I can.

[PabloEForgeFlow]

What do you think about reusing the github_ci_extra_env variable? OCA/oca-addons-repo-template#271

Edit: Just realized I did not take the Travis configuration into account, perhaps it is worth having a dedicated variable.

[sbidoul]

Don't worry about Travis. We don't use it anymore (and I think we can remove it from the template).

About github_ci_extra_env that could work, but we need a default value for 18+ that enables the checklog feature, so it is applied by default when creating new branches with oca/repo-maintainer-conf. A new question would be friendlier, though.

[sbidoul]

Ok, lets merge it to test.

[sbidoul]

Thanks a lot for doing this @PabloEForgeFlow