Skip to content

[18.0][ADD] loyalty_margin_computation: New module - #263

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-add-loyalty_margin_computation
Jun 26, 2026
Merged

[18.0][ADD] loyalty_margin_computation: New module#263
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-add-loyalty_margin_computation

Conversation

@Andrii9090-tecnativa

Copy link
Copy Markdown
Contributor

It is a base module that only adds a field to loyalty.reward to define a formula for margin calculation

@pedrobaeza can you review please?

TT62183
@Tecnativa

Comment thread loyalty_margin_computation/__manifest__.py Outdated
@Andrii9090-tecnativa
Andrii9090-tecnativa force-pushed the 18.0-add-loyalty_margin_computation branch from 71e5576 to 606b317 Compare May 4, 2026 08:27

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eduezerouali-tecnativa eduezerouali-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eduezerouali-tecnativa

Copy link
Copy Markdown

@pedrobaeza can we try to merge this?

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-263-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit e13fe78 into OCA:18.0 Jun 26, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0c38e8c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 18.0-add-loyalty_margin_computation branch June 26, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants