[19.0][MIG] helpdesk_mgmt_sla: Migration to 19.0

[Tomero-Dev]

No description provided.

[Tomero-Dev]

The migration was performed from scratch, preserving the history as Pedro mentioned.
The dependencies were added to the test-requirements file.

[pedrobaeza]

/ocabot migration helpdesk_mgmt_sla

[Yoana-RB]

LGTM Functional review!

[BhaveshHeliconia]

@Tomero-Dev Please squash the commits as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

[Tomero-Dev]

@BhaveshHeliconia I've applied and merged the latest Weblate commits.
I hope this is sufficient.

These are my first verified contributions, and I'm still figuring out exactly what needs to be done.

Thanks.

[BhaveshHeliconia]

@Tomero-Dev It’s still not fully done. Please check the documentation carefully. If you get stuck or need any help, feel free to let me know — I’ll be happy to help.

[skanndar]

Functional review on a clean 19.0 database — LGTM, with two small remarks.

What I tested: official odoo:19 image, fresh database, --without-demo, this PR's branch for helpdesk_mgmt_sla plus helpdesk_mgmt from the 19.0 branch.

• the module installs cleanly and its test suite passes (0 failed, 0 error(s))
• creating a ticket in a team with use_sla applies the matching SLA and computes the deadline from the team calendar (24x7 calendar + 4h SLA → deadline = create_date + 4h)
• moving the clock 5 hours forward: expired and sla_expired both become True, and search([('expired', '=', True)]) / search([('expired', '!=', True)]) include and exclude the record correctly, as does search([('sla_expired', '=', True)]) on tickets
• moving the ticket to the expected stage sets the line to accomplished
• refresh_sla() and helpdesk.sla.report behave as expected

1. test_failed_query no longer covers the guard it was written for. In 18.0 it asserted that an invalid operator reaches _search_expired and raises UserError:

with self.assertRaises(UserError):
    self.env["helpdesk.ticket.sla"].search([("expired", ">", True)])

That cannot be kept as-is in 19.0 — I checked, the ORM rejects the domain earlier with ValueError: Cannot compare 'expired' to <class 'bool'> ..., so _search_expired is never reached. The replacement asserts a successful search instead, so the if operator not in ["=", "!="]: raise UserError guard — which the port still has — is not covered by any test anymore. Calling the search method directly keeps the original intent:

def test_failed_query(self):
    with self.assertRaises(UserError):
        self.env["helpdesk.ticket.sla"]._search_expired(">", True)

2. test-requirements.txt looks droppable now. It pins odoo-addon-helpdesk_mgmt to refs/pull/978/head, but that migration is merged and odoo-addon-helpdesk-mgmt 19.0.1.1.1 is on PyPI, which is why Detect unreleased dependencies is the only red check. Removing that [DON'T MERGE] commit should turn CI green — that plus the squash @BhaveshHeliconia asked for looks like all that is left.

[etobella]

@Tomero-Dev can you check the last comments?

[etobella]

I removed the DO NOT MERGE Commit as the dependancy has been merged 😉

[marcelsavegnago]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[marcelsavegnago]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-1012-by-marcelsavegnago-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 40fdc71. Thanks a lot for contributing to OCA. ❤️