Skip to content

[14.0][IMP] account invoice import simple pdf: add missing values & translation - #791

Closed
klodr wants to merge 2 commits into
OCA:14.0from
klodr:14.0-imp-account_invoice_import_simple_pdf
Closed

klodr wants to merge 2 commits into
OCA:14.0from
klodr:14.0-imp-account_invoice_import_simple_pdf

Conversation

@klodr

@klodr klodr commented Jun 24, 2023

Copy link
Copy Markdown
Contributor

Add some missing values required for some clients.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@klodr
klodr force-pushed the 14.0-imp-account_invoice_import_simple_pdf branch from 57c55e4 to 6599777 Compare June 24, 2023 11:32
@klodr klodr changed the title 14.0 imp account invoice import simple pdf [14.0][IMP] account invoice import simple pdf Jun 24, 2023
@klodr klodr changed the title [14.0][IMP] account invoice import simple pdf [14.0][IMP] account invoice import simple pdf: add missing values & translation Jun 24, 2023
@klodr

klodr commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @klodr you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@klodr

klodr commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

@alexis-via Could review and merge if agreed please ?

@klodr

klodr commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

@florian-dacosta Can you check this ? Thanks @alexis-via seems busy

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via could you have a look at the logic change?

msgid "Missing fixed char."
msgstr ""

#. module: account_invoice_import_simple_pdf

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POT files should be update by https://translation.odoo-community.org/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk
Agreed if you now, how to call the bot to do the job, he's supposed to do ;-)

There is no logical change here we've just add a few case for existing invoice numbers, we've encountered in real life.
That's offering a better security in invoice number detection.

("letter_lower", "Lower Letter"),
("char", "Any Character"),
("space", "Space"),
("fixed", _("Fixed")),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed for selection fields. The orm will flag these terms as translatable.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk not "will flag " => "should theoretically flag"
In fact it's not working so I've added all missing terms.
Let me know if we can do better and force the orm to work

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 11, 2024
@github-actions github-actions Bot closed this Mar 17, 2024
@simahawk

simahawk commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

Shall we reopen this?

@klodr

klodr commented Jul 6, 2024 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants