[18.0][FIX] dms: Remove public read access to trigger redirect - #503
Merged
Conversation
pedrobaeza
reviewed
Aug 11, 2026
Member
|
This was changed in 4595cc8, so @victoralmau can tell us if there's a reason for that. |
christian-ramos-tecnativa
force-pushed
the
18.0-fix-dms
branch
from
August 11, 2026 10:44
5803ffc to
0df4025
Compare
pedrobaeza
approved these changes
Aug 11, 2026
victoralmau
approved these changes
Aug 11, 2026
victoralmau
left a comment
victoralmau
left a comment
Member
There was a problem hiding this comment.
The change seems coherent.
For folders and files, there are already ACLs named base.group_portal and base.group_user.
The important thing is that the URL for accessing a folder works correctly and that a logged-in user can view the appropriate content from /my.
Functionality has been tested.
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 0e2a12d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for the access-token to be processed and redirect to the proper url my/dms/directory... the user access must fail first here https://github.com/OCA/OCB/blob/18.0/addons/portal/controllers/mail.py#L155 otherwise you will be redirected to the login page even with the access token available, to test this:
@Tecnativa TT63966
@pedrobaeza @victoralmau