[15.0] dms_field Access Error You are not allowed to access 'Models' (ir.model) records.

[rrebollo]

Module

dms_field related, probably the root cause is in dms.

Describe the bug

Demo database fresh install. Only Contacts, dms and dms_field installed. Using mark demo user. When trying to access res partner form view in Contacts app de Access Error popups.

To Reproduce

15.0:

Steps to reproduce the behavior:
1.Create demo database
2.Install Contacts, dms and dms_field
3.Log in as mark demo
4.Try to access any record in contacts app

Expected behavior
I was expecting access the record with no errors.

"debug": "Traceback (most recent call last):
  File \"/usr/lib/python3/dist-packages/odoo/tools/cache.py\", line 85, in lookup
    r = d[key]
  File \"/usr/lib/python3/dist-packages/odoo/tools/func.py\", line 71, in wrapper
    return func(self, *args, **kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/tools/lru.py\", line 34, in __getitem__
    a = self.d[obj]
KeyError: ('ir.model.access', <function IrModelAccess.check at 0x7fdd888769d0>, 6, False, 'ir.model', 'read', True, ('en_US',))

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File \"/usr/lib/python3/dist-packages/odoo/addons/base/models/ir_http.py\", line 237, in _dispatch
    result = request.dispatch()
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 698, in dispatch
    result = self._call_function(**self.params)
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 368, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/service/model.py\", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 357, in checked_call
    result = self.endpoint(*a, **kw)
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 921, in __call__
    return self.method(*args, **kw)
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 546, in response_wrap
    response = f(*args, **kw)
  File \"/usr/lib/python3/dist-packages/odoo/addons/web/controllers/main.py\", line 1324, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/addons/web/controllers/main.py\", line 1316, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/api.py\", line 460, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/api.py\", line 433, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/models.py\", line 5061, in search_read
    records = self.search(domain or [], offset=offset, limit=limit, order=order)
  File \"/usr/lib/python3/dist-packages/odoo/models.py\", line 1814, in search
    res = self._search(args, offset=offset, limit=limit, order=order, count=count)
  File \"/usr/lib/python3/dist-packages/odoo/models.py\", line 4728, in _search
    query = self._where_calc(args)
  File \"/usr/lib/python3/dist-packages/odoo/models.py\", line 4484, in _where_calc
    return expression.expression(domain, self).query
  File \"/usr/lib/python3/dist-packages/odoo/osv/expression.py\", line 442, in __init__
    self.parse()
  File \"/usr/lib/python3/dist-packages/odoo/osv/expression.py\", line 708, in parse
    right_ids = comodel.with_context(**field.context)._search([(path[1], operator, right)], order='id')
  File \"/usr/lib/python3/dist-packages/odoo/models.py\", line 4719, in _search
    model.check_access_rights('read')
  File \"/usr/lib/python3/dist-packages/odoo/models.py\", line 3555, in check_access_rights
    return self.env['ir.model.access'].check(self._name, operation, raise_exception)
  File \"<decorator-gen-33>\", line 2, in check
  File \"/usr/lib/python3/dist-packages/odoo/tools/cache.py\", line 90, in lookup
    value = d[key] = self.method(*args, **kwargs)
  File \"/usr/lib/python3/dist-packages/odoo/addons/base/models/ir_model.py\", line 1847, in check
    raise AccessError(msg)
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 654, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File \"/usr/lib/python3/dist-packages/odoo/http.py\", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
odoo.exceptions.AccessError: You are not allowed to access 'Models' (ir.model) records.

This operation is allowed for the following groups:
\t- Administration/Access Rights

Contact your administrator to request access if necessary.
"

[pedrobaeza]

Are you able to reproduce it on OCA runboat?

[rrebollo]

@pedrobaeza yes I could reproduce it on runboat.

[pedrobaeza]

Are you adding any storage?

[rrebollo]

Are you adding any storage?

No, I'm not doing anything. Just what I mentioned in the steps to reproduce the "bug". But in the production database where the problem appeared there are 2 or 3 storages settled.

[pedrobaeza]

Uhm, very weird. Let's see if a dms_field can say about that. Labelling it.

[rrebollo]

@pedrobaeza I got the traceback I showed below inspecting network requests in Chrome. The url is
https://mysite/web/dataset/call_kw/dms.storage/search_read.
The payload from the request is:

{
  "id": 64,
  "jsonrpc": "2.0",
  "method": "call",
  "params": {
    "args": [],
    "model": "dms.storage",
    "method": "search_read",
    "kwargs": {
      "context": {
        "lang": "es_ES",
        "tz": "America/Havana",
        "uid": 47,
        "allowed_company_ids": [
          1
        ]
      },
      "domain": [
        [
          "model_ids.model",
          "=",
          "res.partner"
        ]
      ],
      "fields": [
        "name",
        "count_storage_directories"
      ]
    }
  }
}

With the proper guidance I could contribute to solve or at least clarify the issue. The implications from de error message looks like we need to put every dms user in Administration/Access Rights group but I want to make it right.

[pedrobaeza]

Not sure. Maybe @etobella can say anything.

[rrebollo]

@pedrobaeza @etobella I don't understand all the logic behind dms but the root cause could be related to this field as far as I can go.

[rrebollo]

I could debug the issue and I can confirm the domain settled here ends raising the error cause base.user_group members lack the sufficient access to ir.model. So if we could change model_ids fields to One2many with and explicit intermediate model, then we could set auto_join=True. What do U thing @pedrobaeza @etobella ?

[pedrobaeza]

@victoralmau this problem happened in other module you modified. Do you remember where?

[etobella]

I will propose a PR today.

The same happened here:

https://github.com/OCA/reporting-engine/blob/16.0/base_comment_template/models/base_comment_template.py#L129-L136

[rrebollo]

@pedrobaeza #264 indeed fixes this. This issue is hiiting us in a production environment. Is there anything I can do to speed up the merge?

PD. Btw it's an honor to me just to interact with U guys @pedrobaeza and @etobella. U are legend!!!