[MIG] website_apps_store: Migration to 12.0 - #61
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
@victormmtorres it seems there's something strange in your commit email address. Please check for CLA, and both runbot and Travis are red. |
umiphos
reviewed
May 5, 2019
|
|
||
| def get_author_details(self): | ||
| author_ids = [] | ||
| for variant in self.product_variant_ids: |
There was a problem hiding this comment.
can you try:
Suggested change
| for variant in self.product_variant_ids: | |
| author_ids = variant in self.mapped('product_variant_ids.app_author_ids').ids |
Member
There was a problem hiding this comment.
Not exactly... it should be directly:
return self.mapped('product_variant_ids.app_author_ids')
|
@victormmtorres one fix has been added in v11. |
Member
|
@victormmtorres check also runbot and Travis status |
When the related module has no icon, show a default 'OCA' icon from the static path.
* [IMP] website_apps_store: remove author filter from shop * [FIX]apps_product_creator: fix the broken image path problem with github direct link * [FIX]rename method with proper name * [FIX] solve the problem for renaming function * [FIX] reoved the author test cases
* [IMP] apps-store: - Shop: * Removed filter by author. * Added a more informative placeholder to the searchbox * Added categories of apps to public categories. * Added a filter `All` option for categories dropdown. * Removed sort by price. - Changed the way products are created, now products are related to their correspondant category. (used the ones from Odoo.com/apps) - On PDP added the version of the app if it has no variants. * [REF] if no category found will defailt to 'Other' category
Fix the overflow in the repository URL on the product shop page.
Remove some whitespace.
Remove qweb changes that are made to the product image in the webshop, because they are no longer needed (a default image is set on each product now).
* [FIX]update the product for the new version * [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded * [IMP]added technical name search functionality * change version number * [IMP]Merged create and update product cron job * [FIX]fix variable names
* [FIX][OCA#37]fix rendering from README * [ADD]added CONTRIBUTORS * [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
…A#43) * [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc. * [VER]Added Version number
* [WIP] added initial support for Google recaptcha * [WIP]added dependencies * [IMP]Added google captcha with download functionality with reset and validation * [IMP]added download count fields and increament it when donwloaded * [ADD]added missing files * [IMP]website_apps_store: add sort by download count on website * remove console and not extra space * [VER]changed version number * [FIX]website_apps_store: fix test case error * [FIX]reset only if google recaptcha is initiated
* [FIX][49] solve pager with search parameter * [IMP]website_apps_store : add technical name in front page * [IMP]website_apps_store : add website tour to search technical name * [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py
…href for the repository. OCA#56
martintorresvm
force-pushed
the
12.0-mig-website_apps_store
branch
3 times, most recently
from
May 6, 2019 13:14
cd8b6ab to
04dce07
Compare
Author
|
I've include #64 and missed dependencies hope Travis and Runbot pass |
martintorresvm
force-pushed
the
12.0-mig-website_apps_store
branch
from
May 9, 2019 09:37
04dce07 to
10a61e2
Compare
martintorresvm
force-pushed
the
12.0-mig-website_apps_store
branch
from
May 13, 2019 12:00
10a61e2 to
f6a92a5
Compare
Author
|
Changes done @pedrobaeza |
MiquelRForgeFlow
approved these changes
May 21, 2019
MiquelRForgeFlow
left a comment
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
code review 👍
(although I don't understand the changes in test_website_apps_store.py)
Tardo
reviewed
May 23, 2019
pedrobaeza
approved these changes
May 23, 2019
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Let's move on as this module is inherited from others, but should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa