[11.0] remove default icon for products in the shop - #25
Merged
Conversation
Remove some whitespace.
Remove qweb changes that are made to the product image in the webshop, because they are no longer needed (a default image is set on each product now).
StephanRozendaal
force-pushed
the
11.0-remove-default-icon
branch
from
October 3, 2018 04:14
b0d6f2a to
45182ba
Compare
|
@RoelAdriaans @oscarolar @bizzappdev please review |
|
@gurneyalex could you deploy at your convenience? |
|
@elicoidal IMO this is depending upon OCA/interface-git#27 @StephanRozendaal please confirm |
Author
|
@bizzappdev Yes this depends on the merge of mentioned PR. Sorry was on wrong account before ;) |
Member
|
@sbidoul can you deploy this in OCA instance? |
|
No, not now do not deploy on production. The depending or is still in needs review and open. OCA/interface-git#27 |
Member
|
too late, I just deployed it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change includes: