Skip to content

[16.0][IMP] *: disable auto-install - #1243

Merged
pedrobaeza merged 1 commit into
OCA:16.0from
Tecnativa:16.0-no_auto_install
Jul 9, 2024
Merged

pedrobaeza merged 1 commit into
OCA:16.0from
Tecnativa:16.0-no_auto_install

Conversation

@pedrobaeza

Copy link
Copy Markdown
Member

Odoo chooses to auto-install some modules that are debatable, so here in OCB we can revert this decision and let the Odoo admin to decide about them. This is the second round of de-activations after a deep analysis done in #1242:

  • account_qr_code_sepa: this is just some tooling with no UI, so only modules using this tooling should depend and install it.
  • base_install_request: Feature for asking to install a module that doesn't make too much sense to be auto-installed in on premise maintained installations for avoiding false expectations.
  • mail_bot: It doesn't bring any real feature per se (only the annoying "Write an emoji" initial conversation).
  • pos_epson_printer: Not everyone using PoS has an Epson printer.
  • privacy_lookup: Privacy tool that not everyone uses.

@Tecnativa

Odoo chooses to auto-install some modules that are debatable, so here in
OCB we can revert this decision and let the Odoo admin to decide about
them. This is the second round of de-activations after a deep analysis
done in odoo#1242:

- account_qr_code_sepa: this is just some tooling with no UI, so only
  modules using this tooling should depend and install it.
- base_install_request: Feature for asking to install a module that
  doesn't make too much sense to be auto-installed in on premise
  maintained installations for avoiding false expectations.
- mail_bot: It doesn't bring any real feature per se (only the annoying
  "Write an emoji" initial conversation).
- pos_epson_printer: Not everyone using PoS has an Epson printer.
- privacy_lookup: Privacy tool that not everyone uses.
@pedrobaeza
pedrobaeza merged commit 55fdfb4 into OCA:16.0 Jul 9, 2024
@pedrobaeza
pedrobaeza deleted the 16.0-no_auto_install branch July 9, 2024 15:29
@remi-filament

Copy link
Copy Markdown

Hi @pedrobaeza I am wondering how we decide whether a module should be auto-installed or not ?
From my point of view, that was the purpose of module_change_auto_install created by Sylvain in v14 (and ported to newer versions since very useful, not only for disabling auto_install but also to enable it on modules you always want to install).

If the rationale is integrator knows better and will decide what to install or not, then why not disabling auto_install on all modules (except for glue modules for instance) ?

I agree with your list, except maybe for privacy_lookup which is quite useful to answer data request related to GDPR (but maybe it is less useful outside Europe I would not know).

From my point of view the following ones are also undesirable and could be set to auto_install = False since not everyone uses them (and as a matter of fact I disable those on all of our customer instances) :

  • google_gmail : not everyone is using GMail so why installing this by default ?
  • sms : on many instances noone will pay for sending SMS
  • snailmail : by default you will not buy credits to send mail via post office
  • web_unsplash : by default I do not want my instances to request outside service without being formally installed

Should I go forward and create PR to disable these modules on OCB as well ?

@pedrobaeza

Copy link
Copy Markdown
Member Author

sms and snailmail are not installed as iap auto_install has been disabled. But if you want to install iap and not the others, we can disable them as well.

AFAIK, web_unsplash is not requesting anything until you put the credentials, but it can be disabled as well. Anyway, FYI, Odoo communicates to iap.odoo.com always for the drawings (but without cost - for now -).

Isn't google_gmail auto_install when the other gmail ones are put? If not, indeed it should be disabled.

In general, my criteria is to not install things which are not useful for everyone. I consider both account_edi + web_unsplash as interesting features to have in each installation, but this is subjective.

@remi-filament

Copy link
Copy Markdown

You are right about sms and snailmail, I missed the dependency on iap.
There is only mail dependency on google_gmail so for me it is installed by default as soon as you install mail.
As for web_unsplash, you have a boolean in res.config.settings if you want to activate it, I think it makes more sense not to have it by default and if you have credentials and want to activate it, you click the boolean and then enter credentials.
I will open a PR to disable auto_install on both google_gmail and web_unsplash then !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants