Repository navigation
fix(helm): restore tagged-but-unpublished chart versions automatically - #75
Closed
tim-thacker-nullify wants to merge 1 commit into
Closed
tim-thacker-nullify wants to merge 1 commit into
tim-thacker-nullify wants to merge 1 commit into
Conversation
- Every workflow job sets HELM_REPO_RECOVER_FROM_RELEASES=true, so a version tagged before a failed deploy is restored by the next release on main, and validate reports it as a ::warning:: instead of failing. Recovery still requires the tag on main, the asset to match the chart re-packaged from the tag, and legacy 0.2.0's pinned digest; a version failing any check stops the build. The recover_from_releases dispatch input is removed; the github-pages environment approval is unchanged. - A new version whose release already has a tgz asset is compared by contents instead of by the digest of a fresh helm package, which never matches, and the site then serves the asset's bytes. An asset that cannot be downloaded or does not match its recorded digest still skips the chart. - Recovery finds the chart directory at the tag by Chart.yaml name instead of assuming the directory is named after the chart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 14, 2026
Closed
tim-thacker-nullify
added a commit
that referenced
this pull request
Sep 15, 2026
fix(helm): restore tagged-but-unpublished chart versions automatically Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #70. Round-3 review fixes. Since #70 tags versions before
deploy-pages, a failed deploy left every PR'svalidatered until someone dispatched recovery by hand.validate,publish-dry-runandreleaseall setHELM_REPO_RECOVER_FROM_RELEASES=true:validateemits a::warning::for that version instead of failing.recover_from_releasesdispatch input, which nothing reads now. Thegithub-pagesenvironment approval onreleaseis unchanged.same_contents), not by the digest of a freshhelm package, which is never byte-identical.Chart.yamlname(chart_dir_at), instead of assuminghelm-charts/<name>.Healing needs a
releaserun on main: the next push that touches Helm paths, a re-run of the failed run, or a manual dispatch.Not exercised in CI: recovery against a real missing version, and the asset-contents branch, which is reachable only through a draft release that carries an asset.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.