Skip to content

Refine NU1510 messaging for explicitly referenced auto-available PackageReference dependencies #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkolev92 merged 6 commits into from
May 14, 2026
Merged

Refine NU1510 messaging for explicitly referenced auto-available PackageReference dependencies #7380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c8c2f8b
Initial plan
Copilot May 8, 2026
d03fb21
Update NU1510 wording to force package removal
Copilot May 8, 2026
dcb482e
Use resource-formatted NU1510 message in prune warning test
Copilot May 10, 2026
782f2b6
Use InvariantCulture in NU1510 resource-based test assertion
Copilot May 10, 2026
1475a4a
Refine NU1510 wording for explicitly referenced auto-available packages
Copilot May 13, 2026
3cc0f16
Add explicit NU1510 action to remove PackageReference item
Copilot May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NuGet.Core/NuGet.Commands/Strings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ NuGet requires HTTPS sources. Refer to https://aka.ms/nuget-https-everywhere for
<comment>0 - package id and version, 1 - version</comment>
</data>
<data name="Error_RestorePruningDirectPackageReference" xml:space="preserve">
Comment thread
nkolev92 marked this conversation as resolved.
<value>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</value>
<value>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</value>
<comment>0 - package id and version</comment>
</data>
<data name="Error_RestorePruningProjectReference" xml:space="preserve">
Expand All @@ -1182,4 +1182,4 @@ Upgrade your .NET SDK or remove RestoreUseLegacyDependencyResolver to use this f
<data name="Log_AliasContainsDisallowedCharacters" xml:space="preserve">
<value>The project {0} contains a TargetFramework '{1}' with disallowed characters. TargetFramework names must contain only ASCII characters and must not contain path separators.</value>
</data>
</root>
</root>
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} se nevyřadí. Zvažte odebrání tohoto balíčku ze závislostí, protože je pravděpodobně nepotřebný.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} se nevyřadí. Zvažte odebrání tohoto balíčku ze závislostí, protože je pravděpodobně nepotřebný.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} wird nicht gekürzt. Erwägen Sie, dieses Paket aus Ihren Abhängigkeiten zu entfernen, da es wahrscheinlich nicht erforderlich ist.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} wird nicht gekürzt. Erwägen Sie, dieses Paket aus Ihren Abhängigkeiten zu entfernen, da es wahrscheinlich nicht erforderlich ist.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} no se eliminará. Considere la posibilidad de quitar este paquete de las dependencias, ya que es probable que no sea necesario.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} no se eliminará. Considere la posibilidad de quitar este paquete de las dependencias, ya que es probable que no sea necesario.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">Le PackageReference {0} ne sera pas supprimé. Envisagez de retirer ce package de vos dépendances, car il est probablement inutile.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">Le PackageReference {0} ne sera pas supprimé. Envisagez de retirer ce package de vos dépendances, car il est probablement inutile.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">{0} PackageReference non verrà rimosso. È consigliabile rimuovere questo pacchetto dalle dipendenze, poiché è probabile che non sia necessario.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">{0} PackageReference non verrà rimosso. È consigliabile rimuovere questo pacchetto dalle dipendenze, poiché è probabile che non sia necessario.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} は取り除かれません。このパッケージは不要である可能性があるため、依存関係から削除することを検討してください。</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} は取り除かれません。このパッケージは不要である可能性があるため、依存関係から削除することを検討してください。</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0}은(는) 잘리지 않습니다. 이 패키지는 불필요할 수 있으므로 종속성에서 제거하는 것이 좋습니다.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0}은(는) 잘리지 않습니다. 이 패키지는 불필요할 수 있으므로 종속성에서 제거하는 것이 좋습니다.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">Element PackageReference {0} nie zostanie oczyszczony. Rozważ usunięcie tego pakietu z zależności, ponieważ prawdopodobnie nie jest on potrzebny.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">Element PackageReference {0} nie zostanie oczyszczony. Rozważ usunięcie tego pakietu z zależności, ponieważ prawdopodobnie nie jest on potrzebny.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} não será podado. Considere remover este pacote das dependências, pois ele provavelmente é desnecessário.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} não será podado. Considere remover este pacote das dependências, pois ele provavelmente é desnecessário.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} не будет урезано. Рассмотрите возможность удаления этого пакета из зависимостей, так как он, вероятно, не требуется.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} не будет урезано. Рассмотрите возможность удаления этого пакета из зависимостей, так как он, вероятно, не требуется.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} ayıklanmayacak. Bu paketi bağımlılıklarınızdan kaldırmayı düşünün, çünkü muhtemelen gereksizdir.</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} ayıklanmayacak. Bu paketi bağımlılıklarınızdan kaldırmayı düşünün, çünkü muhtemelen gereksizdir.</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">PackageReference {0} 将不会删除。请考虑从依赖项中移除此包，因为可能不需要它。</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">PackageReference {0} 将不会删除。请考虑从依赖项中移除此包，因为可能不需要它。</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Core/NuGet.Commands/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@
<note />
</trans-unit>
<trans-unit id="Error_RestorePruningDirectPackageReference">
<source>PackageReference {0} will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.</source>
<target state="translated">將不會剪除 PackageReference {0}。請考慮從相依性中移除此套件，因為它可能非必要。</target>
<source>PackageReference {0} will not be pruned. This package is automatically available and does not need to be referenced explicitly. Remove the PackageReference item.</source>
<target state="needs-review-translation">將不會剪除 PackageReference {0}。請考慮從相依性中移除此套件，因為它可能非必要。</target>
<note>0 - package id and version</note>
</trans-unit>
<trans-unit id="Error_RestorePruningProjectReference">
Expand Down
3 changes: 3 additions & 0 deletions test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommand_PrunePackageReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Globalization;
using System.IO;
using System.Linq;
using System.Threading;
Expand Down Expand Up @@ -1330,6 +1331,8 @@ public void AnalyzePruningResults_WithSDKAnalysisLevel_WarnsFor10OrNewerOnly()
var restoreLogMessage = (RestoreLogMessage)testLogger.LogMessages.Single();
restoreLogMessage.Code.Should().Be(NuGetLogCode.NU1510);
restoreLogMessage.LibraryId.Should().Be("A");
restoreLogMessage.Message.Should().Be(
string.Format(CultureInfo.InvariantCulture, Strings.Error_RestorePruningDirectPackageReference, "A"));

testEvent["Pruning.RemovablePackages.Count"].Should().Be(1);
testEvent["Pruning.Pruned.Direct.Count"].Should().Be(1);
Expand Down