Fix no-op issues with SDK resolver#3170
Merged
Merged
Conversation
jeffkl
requested review from
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
nkolev92,
zivkan and
zkat
as code owners
nkolev92
reviewed
Dec 17, 2019
dtivel
reviewed
Dec 17, 2019
dtivel
approved these changes
Dec 17, 2019
* Fixes the issue with the SDK resolver where its called twice at the same time and it tries to write a dgspec file twice. This was caused by the static singleton used for the project name. I'm now generating an entire unique folder and unique project name per restore to ensure this doesn't happen again. * Disabled no-op for SDK restore * Fix code path when no-op is disabled to fully disable no-op logic
…cs and src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/NoOpRestoreUtilities.cs
jeffkl
force-pushed
the
dev-jeffkl-sdk-resolver-fix
branch
from
507931b to
c4ff867
Compare
Contributor
Author
|
@nkolev92 do you approve of this PR? |
💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8692
Fixes: dotnet/runtime#949
Regression: No
Fix
Testing/Validation
Tests Added: No
Reason for not adding tests: Not needed
Validation: Manual