treewide: nuke packages in favour of wallpapers#15
Merged
Conversation
amadaluzia
changed the title
amadaluzia
force-pushed
the
nord
branch
2 times, most recently
from
d28556d to
dda2f7e
Compare
NotAShelf
approved these changes
Feb 1, 2025
NotAShelf
left a comment
NotAShelf
left a comment
Owner
There was a problem hiding this comment.
LGTM.
Ready for merge or do we want to add something to generate the list of wallpapers?
Author
|
I feel as if it would be best to carry a Markdown list generator in another PR. |
Owner
|
Okay sounds good. If you could just add a warning to tell users about what to use instead when |
We have refactored the wallpaper system to be similar to what [yunfachi did with their wallpapers](https://github.com/yunfachi/nix-config-wallpapers). This in turn, had made packaging obsolete and it was decided that it would be removed.
NotAShelf
approved these changes
Feb 1, 2025
NotAShelf
changed the title
Owner
|
thank you |
Open
yunfachi
reviewed
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR aims to change how the wallpaper overlay gets all of its packages.
Why?
I find this may adding wallpaper directories that one little bit more braindead simple.
Additionaly, the
recstatement could be removed by moving wallpkgs to thelet inexpression.