Skip to content

languages/fish: init - #1595

Merged
snoweuph merged 2 commits into
NotAShelf:mainfrom
imnotpoz:fish
May 15, 2026
Merged

languages/fish: init#1595
snoweuph merged 2 commits into
NotAShelf:mainfrom
imnotpoz:fish

Conversation

@imnotpoz

@imnotpoz imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor

picking it up from @poseidon-rises with his permission:
image

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions Bot pushed a commit that referenced this pull request May 15, 2026
@actions-user
Deploy PR #1595 preview
32d70f0
@github-actions

github-actions Bot commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 Live preview deployed from 8b00023

View it here:

Debug Information

Triggered by: imnotpoz

HEAD at: fish

Reruns: 2968

@imnotpoz imnotpoz mentioned this pull request May 15, 2026
Closed
17 tasks
@poseidon-rises

poseidon-rises commented May 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for picking this up!

@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

also fixed a typo I spotted in the example config

snoweuph
snoweuph requested changes May 15, 2026
View reviewed changes

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few Nicks, but generally looks good to me :3

Comment thread modules/plugins/languages/fish.nix Outdated
Comment thread modules/plugins/languages/fish.nix Outdated
Comment thread modules/plugins/languages/fish.nix Outdated
@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

thank you, I gotta admit I did just copy the bash module so it's good to have someone with a functioning brain look over this

all of the above have been addressed

@snoweuph

snoweuph commented May 15, 2026

Copy link
Copy Markdown
Collaborator

According to GitHub, there's no Change from your last push:
image

Did you really add your changes?
Or do I have to pull the tree locally?

@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

sorry my bad I don't know how I fucked that up

@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

should be all good now, shows up correctly on my end

snoweuph
snoweuph approved these changes May 15, 2026
View reviewed changes

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snoweuph

snoweuph commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Gonna Merge as soon as CI passes, just some hick ups, because of GitHubs stupid way to do runtimeLocks 👀

@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

we all up hating on github!!

snoweuph
snoweuph requested changes May 15, 2026
View reviewed changes
Comment thread docs/manual/release-notes/rl-0.9.md Outdated
@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

ok ok ok this time surely

@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

99% of developers stop force pushing 1 time before CI passes

@snoweuph

snoweuph commented May 15, 2026

Copy link
Copy Markdown
Collaborator

99% of developers stop force pushing 1 time before CI passes

--force-with-lease FTW

@imnotpoz

imnotpoz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

--force-with-lease FTW

that's actually very cool, I had no idea this existed, thank you :3c

@imnotpoz
imnotpoz requested a review from snoweuph May 15, 2026 04:31
@snoweuph
snoweuph enabled auto-merge May 15, 2026 04:33
snoweuph
snoweuph approved these changes May 15, 2026
View reviewed changes

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snoweuph
snoweuph merged commit 15fd358 into NotAShelf:main May 15, 2026
14 checks passed
@imnotpoz
imnotpoz deleted the fish branch May 15, 2026 04:34
@snoweuph snoweuph mentioned this pull request Jul 6, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoweuph snoweuph snoweuph approved these changes
@NotAShelf NotAShelf Awaiting requested review from NotAShelf NotAShelf is a code owner
@horriblename horriblename Awaiting requested review from horriblename horriblename is a code owner
@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

Assignees

No one assigned

Labels

topic: documentation topic: modules topic: plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imnotpoz @poseidon-rises @snoweuph