Skip to content

nixos/matrix-synapse: remove web_client option - #81212

Merged
Ma27 merged 1 commit into
NixOS:masterfrom
mmilata:synapse-webclient
Apr 4, 2020
Merged

nixos/matrix-synapse: remove web_client option#81212
Ma27 merged 1 commit into
NixOS:masterfrom
mmilata:synapse-webclient

Conversation

@mmilata

@mmilata mmilata commented Feb 27, 2020

Copy link
Copy Markdown
Member

There is web_client_location as a replacement, however I'm reluctant to add it because it makes it easy to run web client on the same domain as homeserver, which is considered security risk. Maybe if matrix-org/synapse#7006 is merged we can add it with a warning?

Motivation for this change

Option was removed in matrix-synapse-0.34.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 27, 2020
@mmilata
nixos/matrix-synapse: remove web_client option
2acddcb 
Removed in matrix-synapse-0.34.
@mmilata
mmilata force-pushed the synapse-webclient branch from f506adf to 2acddcb Compare April 4, 2020 12:07
@mmilata

mmilata commented Apr 4, 2020

Copy link
Copy Markdown
Member Author

cc @Ma27 @Ralith @roblabla

@ofborg ofborg Bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Apr 4, 2020
@Ma27

Ma27 commented Apr 4, 2020

Copy link
Copy Markdown
Member

@GrahamcOfBorg test matrix-synapse

@Ma27
Ma27 merged commit 5572974 into NixOS:master Apr 4, 2020
@Ma27

Ma27 commented Apr 4, 2020

Copy link
Copy Markdown
Member

@mmilata thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Ralith Ralith Ralith approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmilata @Ma27 @Ralith