Repository navigation
python313Packages.pycxx: fix postInstall - #406664
Conversation
dotlambda
added
the
0.kind: ZHF Fixes
github-actions
Bot
added
6.topic: python
| postInstall = '' | ||
| mkdir -p $dev/include | ||
| mv $out/include/${python.libPrefix}*/CXX/ $dev/include/CXX/ | ||
| mv $out/include/${python.libPrefix}*/cxx/ $dev/include/CXX/ |
There was a problem hiding this comment.
Shouldn't this have also lower-cased the destination directory? As $dev/include/cxx
There was a problem hiding this comment.
Then pysvn fails to build.
There was a problem hiding this comment.
Weird. Do you know what caused this breakage in the first place?
There was a problem hiding this comment.
At least that's what I assumed. But actually that can't be it. I'll try to bisect.
There was a problem hiding this comment.
How about using both upper and lower case? #407387
There was a problem hiding this comment.
Out of curiosity, what made you comment on this?
There was a problem hiding this comment.
Thanks for the bisect!
Out of curiosity, what made you comment on this?
We maintain a fork of nixpkgs internally. After a recent rebase, pycxx broke and I noticed this PR that fixed it. I was just curious about what caused the issue in the first place.
| version = "1.9.23"; | ||
| pyproject = false; | ||
|
|
||
| disabled = pythonAtLeast "3.13"; |
There was a problem hiding this comment.
@dotlambda, why was this disabled for Python 3.13 and above?
The release notes for pysvn (ref) say that v1.9.23 supports Python 3.13:
Latest Version
PySVN 1.9.23 supporting Subversion 1.14.4 and earlier.
Changes:
- Python 3.13 support
- Build binary kits for Windows and macOS
- No longer build svn 1.10 kits as subversion LTS is 1.14 now
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.