treewide: use new cargo fetcher part 6#357268
Closed
Bot-wxt1221 wants to merge 16 commits into
Closed
Conversation
Bot-wxt1221
force-pushed
the
cargo-6
branch
3 times, most recently
from
2241a4b to
339b200
Compare
emilazy
requested changes
Nov 19, 2024
emilazy
left a comment
emilazy
left a comment
Member
There was a problem hiding this comment.
The problems from #356862 remain:
-
Treewide formatting changes mixed into commits that affect the build.
-
No independent review of the scripts and confirmation of reproduction as of yet.
Leaving this as an indicator not to merge until they have been addressed.
13 tasks
This was referenced Nov 19, 2024
ofborg
Bot
added
10.rebuild-darwin: 11-100
wegank
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #357257
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.