Skip to content

treewide: use new cargo fetcher part 2#357263

Closed
Bot-wxt1221 wants to merge 14 commits into
NixOS:masterfrom
Bot-wxt1221:cargo-2
Closed

treewide: use new cargo fetcher part 2#357263
Bot-wxt1221 wants to merge 14 commits into
NixOS:masterfrom
Bot-wxt1221:cargo-2

Conversation

@Bot-wxt1221

Copy link
Copy Markdown
Member

Tracking: #357257

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problems from #356862 remain:

  • Treewide formatting changes mixed into commits that affect the build.

  • No independent review of the scripts and confirmation of reproduction as of yet.

Leaving this as an indicator not to merge until they have been addressed.

@ofborg ofborg Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 20, 2024
@Bot-wxt1221 Bot-wxt1221 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 20, 2024
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 20, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants