neohtop: init at 1.1.1

[HannesGitH]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[HannesGitH]

@NixOS/nix-formatting the formatting check fails if formatted with
nix run '.#nixfmt' 'pkgs/by-name/ne/neohtop/package.nix'
but then recommands using exactly that to format, but it actually requires
nix run '.#nixfmt-rfc-style' 'pkgs/by-name/ne/neohtop/package.nix'

[ambroisie]

A new fetcher has been introduced and its usage is encouraged: #349360.

[HannesGitH]

A new fetcher has been introduced and its usage is encouraged: #349360.

the docs say to use that new fetcher only if cargo lock has git dependencies:

Exception: If the application has cargo git dependencies, the cargoHash approach will not work by default. In this case, you can set useFetchCargoVendor = true to use an improved fetcher that supports handling git dependencies.

but if you say I should use that.. does simply adding useFetchCargoVendor = true; do the trick, or do i need to something else? @ambroisie

[ambroisie]

Hmm, my understanding was that it avoiding us vendoring the Cargo.lock was a plus in all cases.

I'll defer to more knowledgeable Rust maintainers to weight in the.

[JohnRTitor]

Why not use cargoHash and get rid of the lockfile?

[HannesGitH]

because this does not work (cargo cannot find reqwest and the build fails) I think its related to:
https://github.com/HannesGitH/nixpkgs/blob/c43b2b1ea412767dd01e4354f4ca05ff942df4e4/pkgs/by-name/su/surrealist/package.nix#L52-L57

[HannesGitH]

also see #354565 (comment)

[FliegendeWurst]

A meta attribute is required

[FliegendeWurst]

I think you need to include openssl in buildInputs

[ghost]

#354007

[HannesGitH]

I think you need to include openssl in buildInputs

why? it builds and runs as it currently is

[FliegendeWurst]

why? it builds and runs as it currently is

Not on Linux (see ofborg)

[HannesGitH]

why? it builds and runs as it currently is

Not on Linux (see ofborg)

aight i'll quickly add openssl
is added now ✅
lets see

[FliegendeWurst]

It is a little hidden because it will mark a build failure as "neutral".

[pluiedev]

I think the normal way to do this is simply to copy the entire .app folder to $out(maybe share)?

[HannesGitH]

thanks for your feedback, ill hopefully be able to integrate that tomorrow!