Skip to content

matrix-synapse: Use improved user search - #207283

Merged
Ma27 merged 2 commits into
NixOS:masterfrom
mweinelt:synapse-pyicu
Dec 29, 2022
Merged

matrix-synapse: Use improved user search#207283
Ma27 merged 2 commits into
NixOS:masterfrom
mweinelt:synapse-pyicu

Conversation

@mweinelt

@mweinelt mweinelt commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

by propagating pyicu, bindings to libicu, that help to deal with international display names.

Availabl since 1.74.0.

matrix-org/synapse#14464
matrix-org/synapse#14464

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 22, 2022
@ofborg ofborg Bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 22, 2022
lilyinstarlight
lilyinstarlight reviewed Dec 28, 2022
View reviewed changes
Comment thread pkgs/development/python-modules/pyicu/default.nix Outdated
@mweinelt
matrix-synapse: Use improved user search
78555d7 
by propagating pyicu, bindings to libicu, that help to deal with
international display names.
@mweinelt
python3Packges.pyicu: rename from PyICU
bbbb7a7
@Ma27
Ma27 merged commit 891ed93 into NixOS:master Dec 29, 2022
@mweinelt
mweinelt deleted the synapse-pyicu branch December 29, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 approved these changes
@FRidh FRidh Awaiting requested review from FRidh
@jonringer jonringer Awaiting requested review from jonringer
@Ekleog Ekleog Awaiting requested review from Ekleog
@mguentner mguentner Awaiting requested review from mguentner
@sumnerevans sumnerevans Awaiting requested review from sumnerevans
@D4ndellion D4ndellion Awaiting requested review from D4ndellion
@Ralith Ralith Awaiting requested review from Ralith
+1 more reviewer
@lilyinstarlight lilyinstarlight lilyinstarlight left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @lilyinstarlight @Ma27