Skip to content

element: 1.7.27 -> 1.7.28 - #123373

Merged
globin merged 1 commit into
NixOS:masterfrom
TredwellGit:element
May 17, 2021
Merged

globin merged 1 commit into
NixOS:masterfrom
TredwellGit:element

Conversation

@TredwellGit

Copy link
Copy Markdown
Member
Motivation for this change

https://github.com/vector-im/element-web/blob/v1.7.28/CHANGELOG.md
https://github.com/vector-im/element-desktop/blob/v1.7.28/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@TredwellGit TredwellGit added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels May 17, 2021
@TredwellGit
TredwellGit requested a review from Ma27 May 17, 2021 15:02
@ofborg
ofborg Bot requested review from Ekleog, Ralith, fadenb, mguentner, mjlbach and pacien May 17, 2021 15:11
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2021
@r-rmcgibbo

Copy link
Copy Markdown

Result of nixpkgs-review pr 123373 at 25b12b1 run on x86_64-linux 1

2 packages built successfully:
  • element-desktop
  • tests.trivial
3 suggestions:
  • warning: build-tools-in-build-inputs

    rsync is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:292:7:

        |
    292 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
        |       ^
    
  • warning: build-tools-in-build-inputs

    yarn is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:292:7:

        |
    292 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
        |       ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:332:7:

        |
    332 |       installPhase = attrs.installPhase or ''
        |       ^
    

@globin
globin merged commit 7d7efc1 into NixOS:master May 17, 2021
@TredwellGit
TredwellGit deleted the element branch May 17, 2021 21:01
@Ma27

Ma27 commented May 17, 2021

Copy link
Copy Markdown
Member

Since it's a security release I ported it to stable as 42fcae2.

@Ma27 Ma27 added 8.has: port to stable This PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants