fix(release): make Marketplace / Open VSX publish idempotent#126
Merged
Conversation
A transient VS Marketplace gallery timeout can leave some platform VSIXes already published; the publish loop then died on the first 'already exists' on every re-run, so a partial publish could never be completed. Treat an already-published platform as a skip and continue, failing only on real errors. Applies to both the vsce (Marketplace) and ovsx (Open VSX) loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Make the release publish loops tolerant of an already-published platform so a transient gallery timeout no longer leaves the release un-completable.
Details
A transient VS Code Marketplace gallery API timeout (seen on the v0.10.1 release) can leave some platform VSIXes already published. The publish loops used
set -e+ unconditionalvsce/ovsx publish, so every re-run died on the first platform with... already exists, making a partial publish impossible to finish. Both thevsce(Marketplace) andovsx(Open VSX) loops now treat an already-published platform as a skip and continue, failing only on genuine errors, and report published/skipped counts.How Do The Automated Tests Prove It Works?
This changes only release-time publish steps (no app/test code). Validated locally:
release.ymlparses as valid YAML and both modifiedrun:scripts passbash -nsyntax checks. The publish jobs run only onv*tags, so behavior is exercised on the next tagged release.