Repository navigation
feat(registry): Check for changes scans the pinned card's skills again - #1355
Merged
Merged
Conversation
Skills were scored only when a card was previewed, pinned or approved. A refresh now scans the pinned card's skills again and saves the verdicts with it, unless the card was pinned again meanwhile, so an agent's skills can be checked over time and agents pinned before the scan existed get verdicts. A scan that cannot be saved is still answered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KF89yEyaPDgX5rDdR7NMt9
Contributor
Trivy code scan — HIGH/CRITICALNo HIGH or CRITICAL vulnerabilities found. (run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent skills were scored by TrustGuard only when a card was previewed, pinned or approved, so an agent pinned before the scan existed never got verdicts, and a pinned card could not be checked again over time.
POST …/registries/{id}/agent-card/refreshnow scans the pinned card's skills on every call and saves the verdicts with it (PinA2ACardfrom the same digest, keepingcard_pinned_at; nothing is saved if the card was pinned again meanwhile). Registry cache invalidated as approve does.skill_scan(the pinned card's new verdicts).fetched_skill_scanis unchanged: the live card's skills, when it changed.agent skill scan not saved) and the comparison is answered.NewRefreshAgentCardtakes the pinner, cache manager, publisher and logger, asNewApproveAgentCarddoes.docs/a2a.md(Card pinning, Skill scan).Console: NeuralTrust/app (Skills tab shows the new verdicts after Check for changes).
Testing
go test ./pkg/app/registry/... ./pkg/container/... ./pkg/api/handler/http/registry/...Generated by Claude Code