Repository navigation
feat: add Everyone access to the MCP Store (ENG-3054) - #1268
Merged
Merged
Conversation
Exploration, proposal, specs, design and tasks for a per-gateway Everyone Store access and bulk Assign / Remove on Access > Groups.
A gateway can hold one Everyone object: a Store level (open or curated)
and the servers every group passes on, minus excluded groups. This adds
the domain type, the store_everyone table, its repository with an outbox
marker, the service with grant validation, and GET/PUT
/v1/gateways/{gateway_id}/store/everyone. Evaluation and the config
snapshot come next.
A caller reaches Everyone when one of its Store groups is neither excluded nor on a none policy. The level becomes the most permissive of today's result and Everyone's mode, so Everyone never lowers anyone's access and changes nothing when absent. Grant decisions add Everyone's servers for callers who reach it, through the shared loader; the approver keeps writing explicit grants. On the control plane the Store module serves grants, policies and Everyone from one AccessReader.
…s (ENG-3054) The config snapshot carries each gateway's Everyone object in a new field 18, so hybrid and DB-less planes evaluate it like grants and policies; an older plane ignores the field. Deleting a registry drops it from Everyone's grants, and removes the object when a curated one is left without grants. A functional test covers group keys, exclusions, groups on none, install without approval and removal.
- Install honours instance-level Everyone grants, named or picked from the usable instances, like search and the scoper already did. - PUT store/everyone requires mode: a body without it is a 422, not a removal; an empty mode still removes Everyone. - Pruning a deleted registry from Everyone is one locked read-modify-write in the repository, and runs only after the registry delete commits, so a refused delete leaves Everyone untouched. - The registry cleaner and the Everyone DTOs move to their own files; two narrative test comments go.
Contributor
Trivy code scan — HIGH/CRITICALNo HIGH or CRITICAL vulnerabilities found. (run) |
edukmx
marked this pull request as ready for review
November 5, 2026 13:36
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs ENG-3054
Summary
Adds Everyone to the MCP Store: a per-gateway access object that every directory group passes on to its members, except excluded groups and groups whose own policy is
none. It only ever adds access.GET|PUT /v1/gateways/{gateway_id}/store/everyonewith{mode: open|curated, grants: [{catalog_code, registry_id?}], excluded_groups: []}.modeis required; an empty mode removes the object.none, andcuratedwithout grants, are refused (422). Grants are validated like Store grants.store_everyonetable (one row per gateway, FK togatewayswith cascade), repository with an outbox marker so writes rebuild the config snapshot.Setalso allows Everyone's servers (code- or instance-level) to callers who reach it, for search, install, connect, configure and exposure of installed instances. The approver keeps writing explicit grants.Design, specs and tasks:
openspec/changes/access-everyone/.Labelled
size:exception: one PR for the whole TrustGate side was chosen over a chain. Commits are reviewable units (API, evaluation, snapshot, review fixes), with regenerated OpenAPI docs in their own commits.Test plan
make test(pre-commit hook on every commit)go test -raceon changed packages,golangci-lint(0 issues),go vet -tags functional-tags functional,PG_TEST_URL)TestEveryone_GrantsTheStoreToPassingGroupKeys: group keys of passing groups see the server, excluded andnonegroups do not, install without approval, excluded group still files a request, removal takes access away