Annotation problem for Analogsignal in BaseFromRawIO

[hkchekc]

If I am not mistaken, in the baserawio.py and proxyobjects.py, the annotations of the Analogsingal Object cannot be inherited from the rawio.raw_annotations (Unless the length of signal_channel is 1) :

python-neo/neo/io/proxyobjects.py

Line 115 in b4c5950

if len(sig_chans) == 1:

I want to know is that intentional and is there anyway for getting customized annotations through?

Thank you.

[samuelgarcia]

In #461 (proxy and lazy) recently merge, what I did is to add array_annotations in IO.
In short, channel_names and channel_ids are now in array_annotations.
By nature, all annotation that concern all channels should be in array_annotations.

At rawio level, channel annotations are a dict for each channel.
So mapping the list of dict to of one dict (annotation) is obvious only when there is one channel.

For particular annotations that concern all channel, it is easy to create an array_annotation.
I did something similar for it for ChannelIndex here

python-neo/neo/io/basefromrawio.py

Line 135 in b4c5950

keys = list(self.raw_annotations['signal_channels'][ind_abs[0]].keys())

It should be easy to do the same in AnalogSignalProxy.
I can do it.

[hkchekc]

In #461 (proxy and lazy) recently merge, what I did is to add array_annotations in IO.
In short, channel_names and channel_ids are now in array_annotations.
By nature, all annotation that concern all channels should be in array_annotations.

At rawio level, channel annotations are a dict for each channel.
So mapping the list of dict to of one dict (annotation) is obvious only when there is one channel.

For particular annotations that concern all channel, it is easy to create an array_annotation.
I did something similar for it for ChannelIndex here

python-neo/neo/io/basefromrawio.py

Line 135 in b4c5950
keys = list(self.raw_annotations['signal_channels'][ind_abs[0]].keys())

It should be easy to do the same in AnalogSignalProxy.
I can do it.

will be great

[apdavison]

Implemented in #709