Repository navigation
Escape comparison delimiters in generated JavaDoc - #984
Merged
iuliiasobolevska merged 2 commits intoNov 4, 2026
Merged
Conversation
abhinavs1920
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
October 12, 2026 21:06
Preserve balanced inline literals, HTML comments and quoted attributes while escaping comparison text and bare ampersands. Escape comment terminators and eligible Unicode escape backslashes without changing literal rendering. Cover descriptions and deprecation documentation at every Java emission site.
iuliiasobolevska
force-pushed
the
fix-javadoc-comparisons-772
branch
from
November 4, 2026 02:36
0d7d91f to
12a4315
Compare
iuliiasobolevska
approved these changes
Nov 4, 2026
Collaborator
|
Hi @abhinavs1920! Rebased your branch and added the following fixes to strengthen the Javadoc escaping (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #772.
Escape stray
<characters in Java schema descriptions, such ascreated_at:<nowand<=2024, while retaining complete HTML tags and Javadoccode/literalblocks. Applied across data types, interfaces, enums and client descriptions. This is not a general HTML sanitizer.Added a regression that runs JDK 17 Javadoc on the generated sources, plus a markup-preservation check. The generated-source regression fails on master with malformed-HTML errors and passes with this change.
Validation on Linux/JDK 17: 7 focused Javadoc tests passed; Kotlin main/test lint and
git diff --checkpassed. Full core/integration and broader client test runs did not finish within the local execution window, so I cannot claim those passed. Other operating systems were not tested.