Skip to content

Upgrade hystrix-servo-metrics-publisher to newer servo version to become compatible with aws #1700

Closed as not planned

Description

@PeterOsudio

Latest version is compatible with servo 0.10.1 which depends on aws-sdk 1.9.16. When using a newer version of aws-sdk in a project you can run into the following error, because the api has changed.

java.lang.NoSuchMethodError: com.amazonaws.services.cloudwatch.AmazonCloudWatch.putMetricData(Lcom/amazonaws/services/cloudwatch/model/PutMetricDataRequest;)V at com.netflix.servo.publish.cloudwatch.CloudWatchMetricObserver.putMetricData(CloudWatchMetricObserver.java:199) at com.netflix.servo.publish.cloudwatch.CloudWatchMetricObserver.updateImpl(CloudWatchMetricObserver.java:191) at com.netflix.servo.publish.BaseMetricObserver.update(BaseMetricObserver.java:68) at com.netflix.servo.publish.CounterToRateMetricTransform.update(CounterToRateMetricTransform.java:175) at com.netflix.servo.publish.PollRunnable.run(PollRunnable.java:83) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)

This is because AWS changed the return type of AmazonCloudWatch.putMetricData from void to PutMetricDataResult.

I suggest to update the dependency of servo to at least v0.12.4 of servo to overcome this problem.

PS I've seen that this is already done in the 2.0.x branch. When is this one being released.

Activity

  1. added a commit that references this issue on Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions