Pr 1 with path fix - #2
Merged
Merged
Conversation
'Procedure syntax' was removed in Scala 3. Methods must now explicitly declare a return type of `Unit` where applicable.
If you want a different config than the default for your tests, you can always change the symlink to point elsewhere.
- Add modelDir parameter to loadTemplate() and loadFromFile() - Enable config/template file discovery relative to NetLogo model directory - Improve path resolution order for better file location - Update documentation for enhanced path resolution behavior
- Add ujson as explicit dependency (was incorrectly marked as "provided") - Configure assembly to output llm.jar instead of LLM-Extension.jar - Update Java target from 11 to 17 - Add BUILD.md with simple build instructions - Add INSTALL.md with installation guide - Fix test config path to work from demos/tests directory This fixes the NoClassDefFoundError: ujson/Value runtime error by ensuring ujson is bundled in the fat JAR created by sbt assembly.
- Add LICENSE file with BSD 3-Clause license - Update docs/README.md with license section - Addresses legal clarity concerns raised in PR review
JNK234
added a commit
that referenced
this pull request
Feb 16, 2026
I've addressed the path resolution issue you identified in a follow-up branch (`pr-1-with-path-fix`) which includes: - Config/template files now resolve relative to the model file - Added BSD 3-Clause License (addressing legal concerns) Ready for your fuller code review whenever you have time. Appreciate the thorough feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.