Wip test monitors docked - #244
Merged
Merged
Conversation
Contributor
|
I can confirm this has always been a source of trickiness in the JVM NetLogo codebase. The Code and Interface tabs are inherently mutually dependent. Code in the Code tab may refer to sliders, switches, and input boxes in the Interface tab, and the widgets in the Interface may contain code that references code in the Code tab. |
mrerrormessage
force-pushed
the
wip-test-monitors-docked
branch
2 times, most recently
from
June 18, 2015 16:39
0e8d9e5 to
e6a74c9
Compare
Member
There was a problem hiding this comment.
elems.toMap.mapValues(toTortoise)
mrerrormessage
force-pushed
the
wip-test-monitors-docked
branch
from
June 19, 2015 15:22
e6a74c9 to
b23d603
Compare
Contributor
Author
|
Comment addressed. Once the version of tortoise is final, we'll need to update |
Member
|
This looks good. It will be ready for merge once the Tortoise SHA is finalized. |
mrerrormessage
force-pushed
the
wip-test-monitors-docked
branch
from
June 19, 2015 20:18
b23d603 to
2c1f0df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for Galapagos changes which enable NetLogo/Tortoise#12 to work in Galapagos. I do not expect this PR to be merged without serious modification, but I wanted to have something that works to start the discussion off on the right foot.
Within Galapagos, the UI depends on the widgets, and tortoise code depends on the UI. This hasn't been a problem until now because we have simply passed the widgets to the browser as part of a separate data structure. However, as part of Tortoise#12, widgets are now compiled with the rest of the model and put into a variable:
var widgets = [...], so that the UI cannot be constructed before the model is evaluated. However, some code in the model assumes that the UI has been setup prior to it's evaluation, which causes problems. I'm pretty convinced, based on NetLogo-JVM's use of events in GUI loading code, that the problem is at least partially inherent to NetLogo.There may be a number of solutions which I am not clever enough or familiar enough with the code to imagine, and I would really appreciate hearing them. I came up with these:
eval'ed.PlotOpsManagerandPlotOpsProxylisten as the model is loaded and replay the events once the UI has been constructed.eval'ed which performs model setup vis-脿-vis the GUI. Right now, we perform model setup by sticking a bunch of commands at the end, but there's no reason those commands couldn't live in a function which gets called afterevalhas read in the model and the GUI has been setup. This would require some modification in Tortoise, but if we're going this route, the sooner we make those modifications the easier it will be.@TheBizzle , @qiemem, please comment and let me know your thoughts. Unless we can come to a solution before then, I hope we can discuss this (at least briefly) in CCL-Devel tomorrow.