Repository navigation
fix(components-rn): upgrade ant design react native - #19489
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. Walkthrough更新 ChangesRN 依赖更新
Priority: ➖ Normal Estimated code review effort: 1(简单) | ~5 分钟 Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue remains in the reviewed picker adaptation changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 小兔翻开依赖表, Comment |
7af089b to
bb7a8e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19489 +/- ##
==========================================
+ Coverage 55.70% 55.85% +0.14%
==========================================
Files 451 453 +2
Lines 23779 23864 +85
Branches 5881 5914 +33
==========================================
+ Hits 13247 13330 +83
- Misses 8649 8785 +136
+ Partials 1883 1749 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
这个 PR 做了什么? (简要描述所做更改)
问题
@tarojs/components-rn当前固定依赖@ant-design/react-native@5.0.0。该版本的Portal.Host在卸载时调用已废弃的DeviceEventEmitter.removeListener()。在 React Native 0.73 中,这个方法不存在,会抛出TypeError: undefined is not a function并导致应用崩溃。方案
@ant-design/react-native从5.0.0升级到5.1.3。该版本已保存addListener()返回的 subscription,并在卸载时调用subscription.remove()。5.1.3要求的@ant-design/icons-react-native和react-native-gesture-handlerpeer/dev dependencies,避免升级后产生新的 peer dependency 缺失。上游修复:ant-design/ant-design-mobile-rn@78cf9a9
验证
pnpm install --lockfile-only --frozen-lockfile这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit