Skip to content

Add M41L#10

Merged
brysondev merged 2 commits into
NeotokyoRebuild:masterfrom
brysondev:M41L-assets
Oct 17, 2024
Merged

Add M41L#10
brysondev merged 2 commits into
NeotokyoRebuild:masterfrom
brysondev:M41L-assets

Conversation

@brysondev

Copy link
Copy Markdown
Contributor

No description provided.

@Rainyan

Rainyan commented Oct 15, 2024

Copy link
Copy Markdown
Member

Are we cleared in terms of copyright for adding this asset here directly?

@brysondev

Copy link
Copy Markdown
Contributor Author

@blaberry Can you confirm?

@blaberry

Copy link
Copy Markdown
Collaborator

I'm confused, are these modified in any way from the base game? If not, we should not be rehosting them here. If yes, then okay, we needed to patch the ones from the base game, there's a clear need to host them.

@Rainyan

Rainyan commented Oct 15, 2024

Copy link
Copy Markdown
Member

I'm confused, are these modified in any way from the base game? If not, we should not be rehosting them here. If yes, then okay, we needed to patch the ones from the base game, there's a clear need to host them.

The scoped variant of the gun was removed in a prior patch to the original game, so the assets no longer exist in the base game that we mount. So if we want to support it, we'd need to either have our own copy of the model files or figure out some other way of mounting it.

I suppose it's not strictly parity, as the gun doesn't exist in the current iteration of the game, but I can see why people might wanna have it as an option to play around with. Although it kind of lands in the same category as the SMAC and PBK56S.

@brysondev

Copy link
Copy Markdown
Contributor Author

I'm confused, are these modified in any way from the base game? If not, we should not be rehosting them here. If yes, then okay, we needed to patch the ones from the base game, there's a clear need to host them.

@kassibuss sent the files to me from an earlier build of OG and they work just fine. We have 2 PRs open for getting the code up to scratch.

@blaberry

Copy link
Copy Markdown
Collaborator

Thanks for the context, I'm giving the thumbs up to hosting them, we're working on getting the all clear in parallel.

@Rainyan
Rainyan self-requested a review October 16, 2024 07:46
@Agiel

Agiel commented Oct 16, 2024

Copy link
Copy Markdown

The script should be placed in the main repo imo. (And coincidentally, that's where the other scripts are).

@kassibuss

Copy link
Copy Markdown

I'm confused, are these modified in any way from the base game? If not, we should not be rehosting them here. If yes, then okay, we needed to patch the ones from the base game, there's a clear need to host them.

The M41L uses the silenced mosok as a placeholder model in both OGNT and in rebuild, for reasons mentioned before. I probably should have asked beforehand if we should use the original models.

@brysondev
brysondev requested a review from a team October 17, 2024 19:52
@brysondev
brysondev merged commit 7809a37 into NeotokyoRebuild:master Oct 17, 2024
@brysondev
brysondev deleted the M41L-assets branch October 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants